[TSVB] Set listener limit to abort signal correctly #132624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
Feature:TSVB
mistic
reviewed
May 23, 2022
...ins/vis_types/timeseries/server/lib/search_strategies/strategies/abstract_search_strategy.ts
Outdated
Show resolved
Hide resolved
…strategies/abstract_search_strategy.ts Co-authored-by: Tiago Costa <[email protected]>
… into tsvb-event-leak-warning
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
stratoula
added
v8.4.0
auto-backport
stratoula
approved these changes
May 30, 2022
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
that referenced
this pull request
May 30, 2022
(cherry picked from commit eacbbbd)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 30, 2022
(cherry picked from commit eacbbbd) Co-authored-by: Joe Reuter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #132571
by creating a new abort signal per search instead of sharing across all searches of a request (the user controls how many searches are part of a single TSVB request).
Test by creating a TSVB timeseries vis with lots of series - there shouldn't be warnings in Kibana server logs.