Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workplace Search] Fix error loading connector config data on Source Settings view #132320

Merged
merged 2 commits into from
May 17, 2022

Conversation

byronhulcher
Copy link
Contributor

@byronhulcher byronhulcher commented May 17, 2022

Summary

The view was not setting a serviceType prop for AddSourceLogic so when AddSourceLogic.actions.getSourceConfigData() was being called serviceType was undefined.

Introduced in #131802

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #22 / alerting api integration spaces only Alerting bulkEdit should return mapped params after bulk edit

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.5MB 1.5MB +47.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@byronhulcher byronhulcher marked this pull request as ready for review May 17, 2022 14:32
@byronhulcher byronhulcher requested a review from a team May 17, 2022 14:32
@byronhulcher byronhulcher merged commit 8766a9e into elastic:main May 17, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants