-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix map resize + small improvement suggestions #13230
Conversation
@@ -22,8 +22,9 @@ function serializer() { | |||
} | |||
|
|||
const getUpdateStatus = ($scope) => { | |||
if (!$scope._oldStatus) $scope._oldStatus = []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_oldStatus should be string-map iso array i think
if (status.resize) { | ||
this._kibanaMap.resize(); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reorder to ensure map always resizes, even if no data on map
@thomasneirynck i think the issue is actually much smaller. render method does trigger on collapse, however the indication if the size has changed or not was not implemented correctly. take a look at #13239 where the bug is fixed with minimal changes. |
closing this in favor of #13239, which is a m uch smaller fix |
Closes #12983.
This addresses actually a couple of things:
maps_visualization
that the map would not resize if no data was present. This is somewhat theoretical, but it's a possibility.