Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization accessibility issues #13226

Merged
merged 6 commits into from
Aug 3, 2017
Merged

Visualization accessibility issues #13226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
300a4b0
add role search
thomasneirynck Jul 31, 2017
cab9c04
make sure index-pattern is keyboard accessible
thomasneirynck Aug 1, 2017
d9677ae
pair from/to labels
thomasneirynck Aug 1, 2017
0f20f7f
make aggs part of tab-order
thomasneirynck Aug 1, 2017
43b9033
add for labels
thomasneirynck Aug 2, 2017
e8f4347
review feedback 2
thomasneirynck Aug 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/core_plugins/kbn_vislib_vis_types/public/controls/heatmap_options.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,16 +109,17 @@
<table class="vis-editor-agg-editor-ranges form-group" ng-show="vis.params.colorsRange.length">
<tr>
<th>
<label>From</label>
<label id="heatmapCustomRangeFrom">From</label>
</th>
<th colspan="2">
<label>To</label>
<label id="heatmapCustomRangeTo">To</label>
</th>
</tr>

<tr ng-repeat="range in vis.params.colorsRange track by $index">
<td>
<input
aria-labelledby="heatmapCustomRangeFrom"
ng-model="range.from"
type="number"
class="form-control"
Expand All @@ -128,6 +129,7 @@
</td>
<td>
<input
aria-labelledby="heatmapCustomRangeTo"
ng-model="range.to"
type="number"
class="form-control"
Expand Down
2 changes: 1 addition & 1 deletion src/core_plugins/kibana/public/visualize/wizard/step_1.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ <h1 class="kuiTitle kuiVerticalRhythm kuiVerticalRhythm--medium">
</h1>

<!-- Search -->
<div class="kuiSearchInput kuiVerticalRhythm kuiVerticalRhythm--medium fullWidth">
<div class="kuiSearchInput kuiVerticalRhythm kuiVerticalRhythm--medium fullWidth" role="search">
<div class="kuiSearchInput__icon kuiIcon fa-search"></div>
<input
class="kuiSearchInput__input"
Expand Down
2 changes: 2 additions & 0 deletions src/ui/public/vis/editors/default/agg_add.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
<label>Select {{ groupName }} type</label>
<ul class="form-group list-group list-group-menu">
<li
tabindex="0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tabindex unfortunately also needs the id attribute on this element to work properly. We documented this in the styleguide

id="aggSchemaListItem-{{$index}}"
ng-hide="schema.deprecate"
ng-repeat="schema in availableSchema"
ng-click="add.submit(schema)"
Expand Down
2 changes: 2 additions & 0 deletions src/ui/public/vis/editors/default/sidebar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
aria-label="{{:: 'Index pattern: ' + vis.indexPattern.title}}"
ng-if="vis.type.requiresSearch"
class="index-pattern"
tabindex="0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

id="sidebarIndexPatternTitle"
>
{{ vis.indexPattern.title }}
</div>
Expand Down