[Dashboard] Add Analytics No Data Page #132188

ThomThomson · 2022-05-12T22:08:46Z

Fixes #132144

Summary

Adopts the Shared UX no data component in the Dashboard listing page, and in the dashboard app.

Add integrations callout in dashboard

Creating a Data View from the create Dashboard route

Creating a Data View from the Dashboard Listing route

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

…and dashboard listing page

elasticmachine · 2022-05-19T19:13:02Z

Pinging @elastic/kibana-presentation (Team:Presentation)

tsullivan

LGTM

reviewed app services change + ran locally

Heenawter

Tested locally + code review - one tiny question but otherwise works great! 👍

Heenawter · 2022-05-19T20:41:12Z

test/functional/apps/dashboard/group4/index.ts

+    // loadTestFile(require.resolve('./dashboard_time'));
+    // loadTestFile(require.resolve('./dashboard_listing'));
+    // loadTestFile(require.resolve('./dashboard_clone'));


Is there a reason these other tests are commented out?

I commented them out just for testing purposes. That would have been bad. Thank you for catching this.

majagrubic

Let's not merge this until the issue with permissions is resolved, I'll keep you updated.

majagrubic · 2022-05-20T12:16:54Z

src/plugins/dashboard/public/application/dashboard_app_empty.tsx

+    return true;
+  }
+
+  const defaultDataView = await dataViews.getDefaultDataView();


is this check necessary for Dashboard?

That's a good question. The older version of this code had an ensureDefaultDataView check, so it seems to have been required before, but I can't exactly understand why. If there are any data views, surely one of them should be default, no?

Is there a reason this was required for Discover?

if memory serves well, in Discover, you save a saved search with a data view. if all data views get deleted and you try opening a saved search, that would throw an error. That's why the check. That being said, it was there before checking for existence of any data view, so I am not sure if it's relevant any more.

Seems like it should all work the same. I will remove this from the dashboard side!

majagrubic · 2022-05-20T12:23:52Z

src/plugins/dashboard/public/application/dashboard_app_empty.tsx

+  );
+};
+
+export const isDashboardAppEmpty = async (dataViews: DataPublicPluginStart['dataViews']) => {


just a nit: we're trying to standardize terminology in a way that by "no data" we refer to "there is no data in ES or there are no data views". by "empty" we refer to "this app is empty", aka there is data, but there are no dashboards yet. can we rename this to something like "noDataCheck" or "hasData" or even "canUseDashboard"?

Ah, I will rename all of these. Naming is important, thank you for pointing this out!

majagrubic · 2022-05-20T12:24:32Z

x-pack/test/functional/apps/dashboard/group1/reporting/screenshots.ts

@@ -47,7 +47,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
          indices: [
            {
              names: ['ecommerce', 'kibana_sample_data_ecommerce'],
-              privileges: ['read'],
+              privileges: ['read', 'view_index_metadata'],


Let's not change permissions here as this is a valid test case that caught a pretty big error.

Aye aye, will undo this now that the fix is merged in!

majagrubic · 2022-05-20T14:16:42Z

The app-services change has been merged: #132618

Can you try removing the additional privilege in the functional test and see if this works?

ThomThomson · 2022-05-20T20:12:00Z

@elasticmachine merge upstream

majagrubic · 2022-05-23T17:58:26Z

@elasticmachine merge upstream

kibana-ci · 2022-05-24T19:12:59Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`dashboard`	266	375	+109

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`dashboard`	304.4KB	439.6KB	+135.2KB

Unknown metric groups

async chunk count

id	before	after	diff
`dashboard`	3	10	+7

miscellaneous assets size

id	before	after	diff
`dashboard`	0.0B	161.8KB	+161.8KB

History

💔 Build #47026 failed fdc03d2
💔 Build #46639 failed 37a1afe
💔 Build #46604 failed c8b6d1b
💚 Build #46261 succeeded 7e2e665
💛 Build #46221 was flaky 405cf21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

majagrubic

I pushed a commit that re-introduces a check for default data view. That actually does more than just check for one; it loads a default data view if there is none. This is needed in case of switching spaces, where a wrong data view could stay associated with the dashboard and dashboard would try to load the data from the data view from a previous space (which doesn't exist in a current space). Sorry for leading you down the wrong path.
Also approving this for no data changes, so that it doesn't block merging.

ThomThomson added 6 commits May 12, 2022 18:07

initial addition of no data and no data view states to dashboard app …

e596100

…and dashboard listing page

Merge branch 'main' of github.com:elastic/kibana into dashboard/no-data

996f915

fix types and mocks

a917c2a

add and fix functional tests

fe2e291

Merge branch 'main' of github.com:elastic/kibana into dashboard/no-data

f225c59

fix dashboard empty tests

8b52d97

load data in dashboard save tests if needed.

405cf21

ThomThomson marked this pull request as ready for review May 19, 2022 19:13

ThomThomson requested review from a team as code owners May 19, 2022 19:13

tsullivan approved these changes May 19, 2022

View reviewed changes

Heenawter approved these changes May 19, 2022

View reviewed changes

uncomment dashboard group 4 tests

7e2e665

majagrubic suggested changes May 20, 2022

View reviewed changes

ThomThomson added 4 commits May 20, 2022 13:16

rename dashboard_app_empty to dashboard_app_no_data

fe2cbb1

remove view_index_metadata privilege from screenshot tests

4d695a7

Merge branch 'main' of github.com:elastic/kibana into dashboard/no-data

01dc098

remove default data view check from dashboard_app_no_data

c8b6d1b

Merge branch 'main' into dashboard/no-data

37a1afe

Merge branch 'main' into dashboard/no-data

fdc03d2

Ensure default data view

ba9bdeb

majagrubic approved these changes May 24, 2022

View reviewed changes

ThomThomson merged commit 556b491 into elastic:main May 24, 2022

kibanamachine added the backport:skip This commit does not require backporting label May 24, 2022

ThomThomson mentioned this pull request Jun 14, 2023

[Dashboard] Welcome page shown when dashboard with ad-hoc data view exists #159628

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dashboard] Add Analytics No Data Page #132188

[Dashboard] Add Analytics No Data Page #132188

ThomThomson commented May 12, 2022 •

edited

Loading

elasticmachine commented May 19, 2022

tsullivan left a comment •

edited

Loading

Heenawter left a comment

Heenawter May 19, 2022

ThomThomson May 19, 2022

ThomThomson May 19, 2022

majagrubic left a comment

majagrubic May 20, 2022

ThomThomson May 20, 2022

majagrubic May 20, 2022

ThomThomson May 20, 2022

majagrubic May 20, 2022 •

edited

Loading

ThomThomson May 20, 2022

majagrubic May 20, 2022

ThomThomson May 20, 2022

majagrubic commented May 20, 2022

ThomThomson commented May 20, 2022

majagrubic commented May 23, 2022

kibana-ci commented May 24, 2022

async chunk count

miscellaneous assets size

majagrubic left a comment •

edited

Loading

[Dashboard] Add Analytics No Data Page #132188

[Dashboard] Add Analytics No Data Page #132188

Conversation

ThomThomson commented May 12, 2022 • edited Loading

Summary

Add integrations callout in dashboard

Creating a Data View from the create Dashboard route

Creating a Data View from the Dashboard Listing route

Checklist

elasticmachine commented May 19, 2022

tsullivan left a comment • edited Loading

Choose a reason for hiding this comment

Heenawter left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

majagrubic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

majagrubic May 20, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

majagrubic commented May 20, 2022

ThomThomson commented May 20, 2022

majagrubic commented May 23, 2022

kibana-ci commented May 24, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

async chunk count

miscellaneous assets size

History

majagrubic left a comment • edited Loading

Choose a reason for hiding this comment

ThomThomson commented May 12, 2022 •

edited

Loading

tsullivan left a comment •

edited

Loading

majagrubic May 20, 2022 •

edited

Loading

majagrubic left a comment •

edited

Loading