Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip flaky Saved Objects Management <> spaces test #132015

Merged
merged 1 commit into from
May 12, 2022
Merged

Unskip flaky Saved Objects Management <> spaces test #132015

merged 1 commit into from
May 12, 2022

Conversation

legrego
Copy link
Member

@legrego legrego commented May 11, 2022 •
edited
Loading

Resolves #115303, with no code changes 😬.

I suspect that recent EUI changes improved the rendering of tables, so we aren't susceptible to the partial rendering that we were seeing in #115303.

Flaky test runner results:

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@legrego legrego added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.3.0 v7.17.4 labels May 11, 2022
@legrego legrego marked this pull request as ready for review May 11, 2022 14:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@legrego legrego requested a review from a team May 11, 2022 14:08
azasypkin
azasypkin approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@legrego legrego removed auto-backport Deprecated - use backport:version if exact versions are needed v7.17.4 labels May 12, 2022
@legrego legrego merged commit 6633242 into elastic:main May 12, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 12, 2022
@legrego legrego deleted the som/flaky-spaces-test branch May 12, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azasypkin azasypkin azasypkin approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.3.0
Projects
None yet
Milestone
No milestone
5 participants
@legrego @kibana-ci @elasticmachine @azasypkin @kibanamachine