Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cases] Cases e2e tests update for severity field #131795

Merged
merged 71 commits into from
May 9, 2022

Conversation

academo
Copy link
Contributor

@academo academo commented May 9, 2022

Summary

updates the existing e2e test to include the new severity field and add some other dedicated e2e tests for it.

Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/571#73618a80-5e87-4768-b721-8a754460a03d

Esteban Beltran and others added 30 commits May 3, 2022 14:18
… "long" in Elasticsearch) (elastic#130819)

* Convert event.duration to string in TypeScript, keep as long in Elasticsearch

* Fix jest test

* Fix functional tests

* Add ecsStringOrNumber to event log schema

* Fix jest test

* Add utility functions to event log plugin

* Use new event log utility functions

* PR fixes

Co-authored-by: Kibana Machine <[email protected]>
…131232)

* Add fix license link

* fix localization

* fix CI error

* fix more translation issues

Co-authored-by: Kibana Machine <[email protected]>
* rule state filter

* turn off experiment

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* Status filter API call

* Fix tests

* rename state to status, added tests

* Address comments and fix tests

* Revert experiment flag

* Remove unused translations

* Addressed comments

Co-authored-by: kibanamachine <[email protected]>
* [storybook] Watch for changes in packages

* Update default_config.ts
* adjust vega doc

* Update docs/user/dashboard/vega-reference.asciidoc

Co-authored-by: Nick Peihl <[email protected]>

* Update docs/user/dashboard/vega-reference.asciidoc

Co-authored-by: Nick Peihl <[email protected]>

* Update docs/user/dashboard/vega-reference.asciidoc

Co-authored-by: Nick Peihl <[email protected]>

* Update docs/user/dashboard/vega-reference.asciidoc

Co-authored-by: Nick Peihl <[email protected]>

* Update docs/user/dashboard/vega-reference.asciidoc

Co-authored-by: Nick Peihl <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Nick Peihl <[email protected]>
@academo academo added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.3.0 labels May 9, 2022
@academo academo requested review from peteharverson and cnasikas May 9, 2022 11:29
@academo academo self-assigned this May 9, 2022
@academo academo requested a review from a team as a code owner May 9, 2022 11:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@@ -184,9 +185,35 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {
await common.clickAndValidate('property-actions-ellipses', 'property-actions-trash');
await common.clickAndValidate('property-actions-trash', 'confirmModalConfirmButton');
await testSubjects.click('confirmModalConfirmButton');
await testSubjects.existOrFail('cases-all-title', { timeout: 2000 });
await header.waitUntilLoadingHasFinished();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes this test flakyness.

Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LTGM!

@academo academo enabled auto-merge (squash) May 9, 2022 15:05
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #12 / dashboard app - group 2 dashboard saved queries saved query management component functionality should allow a query to be saved via the saved objects management component

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @academo

@academo academo merged commit 79d5704 into elastic:main May 9, 2022
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.