[Cases] severity field in the cases list and allow to filter by it #131694

academo · 2022-05-06T08:50:39Z

Summary

Introduces

The severity field in the cases list table
The severity filter
API modifications to allow filtering by severity field
API integration tests
Related unit tests

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and xincludes i18n support
Unit or functional tests were updated or added to match the most common scenarios
[x]] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

…ity-field

… "long" in Elasticsearch) (elastic#130819) * Convert event.duration to string in TypeScript, keep as long in Elasticsearch * Fix jest test * Fix functional tests * Add ecsStringOrNumber to event log schema * Fix jest test * Add utility functions to event log plugin * Use new event log utility functions * PR fixes Co-authored-by: Kibana Machine <[email protected]>

…astic#131277)

Co-authored-by: Kibana Machine <[email protected]>

…131232) * Add fix license link * fix localization * fix CI error * fix more translation issues Co-authored-by: Kibana Machine <[email protected]>

* rule state filter * turn off experiment * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Status filter API call * Fix tests * rename state to status, added tests * Address comments and fix tests * Revert experiment flag * Remove unused translations * Addressed comments Co-authored-by: kibanamachine <[email protected]>

* [storybook] Watch for changes in packages * Update default_config.ts

)

* adjust vega doc * Update docs/user/dashboard/vega-reference.asciidoc Co-authored-by: Nick Peihl <[email protected]> * Update docs/user/dashboard/vega-reference.asciidoc Co-authored-by: Nick Peihl <[email protected]> * Update docs/user/dashboard/vega-reference.asciidoc Co-authored-by: Nick Peihl <[email protected]> * Update docs/user/dashboard/vega-reference.asciidoc Co-authored-by: Nick Peihl <[email protected]> * Update docs/user/dashboard/vega-reference.asciidoc Co-authored-by: Nick Peihl <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Nick Peihl <[email protected]>

…ity-field

elasticmachine · 2022-05-09T07:10:52Z

Pinging @elastic/response-ops (Team:ResponseOps)

elasticmachine · 2022-05-09T07:10:54Z

Pinging @elastic/response-ops-cases (Feature:Cases)

academo · 2022-05-09T07:12:06Z

x-pack/plugins/cases/public/components/all_cases/columns.tsx

@@ -300,30 +302,6 @@ export const useCasesColumns = ({
        return getEmptyTagValue();
      },
    },
-    ...(isSelectorView


This section was merely moved down to allow the severity field to show before the status.

academo · 2022-05-09T07:15:05Z

x-pack/plugins/cases/public/components/status/translations.ts

@@ -9,7 +9,7 @@ import { i18n } from '@kbn/i18n';
 export * from '../../common/translations';

 export const ALL = i18n.translate('xpack.cases.status.all', {
-  defaultMessage: 'All',
+  defaultMessage: 'All status',


Copy change required to clarify the "All" in the status filter dropdown now that the severity field was added.

cnasikas

Code LGTM. I tested locally and everything is working as expected.

I noticed that the "All severity" item is on the bottom when you open the dropdown. Could you please move it to the top? Same as the "All statuses".

x-pack/plugins/cases/server/client/utils.ts

x-pack/test/cases_api_integration/security_and_spaces/tests/common/cases/find_cases.ts

x-pack/test/functional/fixtures/kbn_archiver/cases/8.2.0/cases_various_dates.json

kibana-ci · 2022-05-09T10:31:58Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`cases`	425	426	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cases`	293.7KB	296.7KB	+3.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`cases`	112.1KB	112.2KB	+77.0B

History

💚 Build #43234 succeeded a1a54dd
💛 Build #43014 was flaky b342e20
💛 Build #42971 was flaky 2577132

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @academo

peteharverson

Tested and LGTM.

Created a separate enhancement request #131806 to persist / restore the filter settings, including the severity,to the URL

…lastic#131694)

Esteban Beltran and others added 30 commits May 3, 2022 14:18

Add severity field to create API and migration

8abc0d3

Adds integration test for severity field migration

c7986b0

remove exclusive test

8ff9f9b

Change severity levels

04c413e

Update integration tests for post case

9d488bc

Add more integration tests

13f3406

Fix all cases list test

a749da5

Fix some server test

f76213a

Fix util server test

d62bf70

Fix client util test

8906ccd

Merge remote-tracking branch 'upstream/main' into feature/cases-sever…

99923ec

…ity-field

Merge branch 'main' into feature/cases-severity-field

ede3328

filter o11y rule aggregations (elastic#131301)

bcb2ab1

[Cloud Posture] Display and save rules per benchmark (elastic#131412)

7caa070

Adding aria-label for discover data grid select document checkbox (el…

ed7c949

…astic#131277)

Update API docs (elastic#130999)

e120e56

Co-authored-by: Kibana Machine <[email protected]>

[CI] Use GCS buckets for bazel remote caching (elastic#131345)

16467d1

[Actionable Observability] Add license modal to rules table (elastic#…

1186b3e

…131232) * Add fix license link * fix localization * fix CI error * fix more translation issues Co-authored-by: Kibana Machine <[email protected]>

[storybook] Watch for changes in packages (elastic#131467)

f11b843

* [storybook] Watch for changes in packages * Update default_config.ts

Improve saved objects migrations failure errors and logs (elastic#131359

c574ab6

)

[Unified observability] Add tour step to guided setup (elastic#131149)

fed45c9

[Lens] Improved interval input (elastic#131372)

9dd98b9

Merge remote-tracking branch 'upstream/main' into feature/cases-sever…

e2b8cf4

…ity-field

Excess intersections

de4a093

Create severity user action

87f2cd5

Add severity selector to the case vie wpage

6958994

Add test cases for the severity field

23417a1

academo commented May 9, 2022

View reviewed changes

Esteban Beltran added 3 commits May 9, 2022 09:15

remove comment

b6672a9

update tests for the api

da96a48

Update useGetCases test

a1a54dd

cnasikas reviewed May 9, 2022

View reviewed changes

x-pack/plugins/cases/server/client/utils.ts Show resolved Hide resolved

x-pack/test/cases_api_integration/security_and_spaces/tests/common/cases/find_cases.ts Show resolved Hide resolved

Esteban Beltran added 2 commits May 9, 2022 11:11

Add test for rbac

ec674cc

Fix severities order

5b168a3

academo requested a review from cnasikas May 9, 2022 09:15

cnasikas reviewed May 9, 2022

View reviewed changes

x-pack/test/cases_api_integration/security_and_spaces/tests/common/cases/find_cases.ts Outdated Show resolved Hide resolved

Change test title

bbd09d0

cnasikas reviewed May 9, 2022

View reviewed changes

x-pack/test/functional/fixtures/kbn_archiver/cases/8.2.0/cases_various_dates.json Outdated Show resolved Hide resolved

Esteban Beltran added 3 commits May 9, 2022 11:24

Rollback fixture changes

775b2bb

add cases for severity fitert

bb05c1e

update comment

5d33d28

cnasikas approved these changes May 9, 2022

View reviewed changes

peteharverson mentioned this pull request May 9, 2022

[Cases] Persist filter settings in Cases list to the URL #131806

Closed

peteharverson approved these changes May 9, 2022

View reviewed changes

academo merged commit 190ed55 into elastic:main May 9, 2022

academo deleted the feature/cases-severity-field-list-table branch May 9, 2022 13:47

cnasikas mentioned this pull request May 10, 2022

[Cases] Add Severity field to cases #130019

Closed

5 tasks

This was referenced May 17, 2022

[DOCS] 8.3 screenshot updates for Cases elastic/security-docs#1995

Closed

[DOCS] Refresh cases screenshot elastic/observability-docs#1880

Merged

kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022

[Cases] severity field in the cases list and allow to filter by it (e…

c37fd01

…lastic#131694)

cnasikas added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:feature Makes this part of the condensed release notes labels May 27, 2022

nastasha-solomon mentioned this pull request Jun 1, 2022

[DOCS] Users can assign a severity level to a case elastic/security-docs#2037

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cases] severity field in the cases list and allow to filter by it #131694

[Cases] severity field in the cases list and allow to filter by it #131694

academo commented May 6, 2022 •

edited

Loading

elasticmachine commented May 9, 2022

elasticmachine commented May 9, 2022

academo May 9, 2022

academo May 9, 2022

cnasikas left a comment

kibana-ci commented May 9, 2022

peteharverson left a comment

[Cases] severity field in the cases list and allow to filter by it #131694

[Cases] severity field in the cases list and allow to filter by it #131694

Conversation

academo commented May 6, 2022 • edited Loading

Summary

Checklist

elasticmachine commented May 9, 2022

elasticmachine commented May 9, 2022

academo May 9, 2022

Choose a reason for hiding this comment

academo May 9, 2022

Choose a reason for hiding this comment

cnasikas left a comment

Choose a reason for hiding this comment

kibana-ci commented May 9, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

peteharverson left a comment

Choose a reason for hiding this comment

academo commented May 6, 2022 •

edited

Loading