Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug log on task run end #131639

Merged
merged 4 commits into from
May 10, 2022
Merged

Add debug log on task run end #131639

merged 4 commits into from
May 10, 2022

Conversation

ersin-erdal
Copy link
Contributor

@ersin-erdal ersin-erdal commented May 5, 2022 •
edited
Loading

fixes: #131090

This PR intends to add a debug log on task end.
It also adds task:start task:end task.id and task.taskType as tags to both start and end logs

@ersin-erdal ersin-erdal added release_note:skip Skip the PR/issue when compiling release notes Feature:Task Manager Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.3.0 labels May 5, 2022
@ersin-erdal ersin-erdal marked this pull request as ready for review May 6, 2022 13:44
@ersin-erdal ersin-erdal requested a review from a team as a code owner May 6, 2022 13:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

ymao1
ymao1 approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Verified I can see the debug log on task end

gmmorris
gmmorris approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@gmmorris gmmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

pmuellr
pmuellr approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ersin-erdal ersin-erdal merged commit 2a51a37 into elastic:main May 10, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 10, 2022
@ersin-erdal ersin-erdal deleted the 131090-tm-debug-log branch May 10, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymao1 ymao1 ymao1 approved these changes

@gmmorris gmmorris gmmorris approved these changes

@pmuellr pmuellr pmuellr approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Task Manager release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ResponseOps][taskManager] add debug log message when task ends
7 participants
@ersin-erdal @elasticmachine @kibana-ci @pmuellr @gmmorris @ymao1 @kibanamachine