-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FullStory] Document browser exposed config in the test #131527
[FullStory] Document browser exposed config in the test #131527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the comment!
@@ -165,6 +165,7 @@ export default function ({ getService }: PluginFunctionalProviderContext) { | |||
'xpack.cloud.deployment_url (string)', | |||
'xpack.cloud.full_story.enabled (boolean)', | |||
'xpack.cloud.full_story.org_id (any)', | |||
// No PII. Just the list of event types we want to forward to FullStory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: just for my own education (noob in FullStory) - are these just arbitrary strings, or Full Story has a predefined list of these events.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These strings are not mandated by FullStory. This config is used to filter the events from EBT that we actually want to send to FullStory. It has a very aggressive rate limiting policy regarding custom events (up to 10 events per second and 30 per minute), so we want to send only the events from Kibana that we really want to have in FullStory. All the events will still go to our Remote Telemetry Service, it's just a filter to the FullStory endpoint.
Right now it's just ['Loaded Kibana']
because it's the only event we used to send to FullStory from the start. It may grow to match the name of the events we want to forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks for the detailed explanation.
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
Summary
Follow up to #131148 to address NIT comment.
For maintainers