[Security Solution][Investigations] - Add pagination to alert details table #131358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelolo24
added
bug
michaelolo24
force-pushed
the
paginate-details-table
branch
from
1a7084c to
13da73d
Compare
michaelolo24
changed the title
9 tasks
|
@elasticmachine merge upstream |
kqualters-elastic
approved these changes
May 10, 2022
janmonschke
approved these changes
May 10, 2022
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
that referenced
this pull request
May 11, 2022
… table (#131358) Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit c0e03c8)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 11, 2022
… table (#131358) (#132065) Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit c0e03c8) Co-authored-by: Michael Olorunnisola <[email protected]>
academo
pushed a commit
to academo/kibana
that referenced
this pull request
May 12, 2022
… table (elastic#131358) Co-authored-by: Kibana Machine <[email protected]>
tylersmalley
added
ci:cloud-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces pagination to the alert details flyout table in all views where it is used. This limits the number of fields which are rendered on load for the flyout, providing performance improvements when hundreds or thousands of fields may render. The preset options of [25, 50, 100] are based on the selection options in discover. The details flyout table is used in the following views: case details page, alerts page, rule details page, host event details page, host external alerts page and timeline views: query tab, correlation tab, session tab, and pinned tab.
Preserving the pagination options was done separately here: michaelolo24#3
Dev tools was used to add 2000+ dummy fields for testing between main and this branch. The same data was used for both videos below, as the branch was just switched.
Before pagination introduction (currently on main):
Screen.Recording.2022-05-04.at.11.22.02.AM.mov
After the introduction of pagination (this branch):
Screen.Recording.2022-05-04.at.11.26.21.AM.mov
The only items changed in the code was the introduction of pagination to the EuiInMemoryTable for the table following the documentation regarding pagination here: https://elastic.github.io/eui/#/tabular-content/in-memory-tables
The only teams impacted by this are teams that utilize this table in the details flyout, which would be the threat hunting investigations and explore teams as well as the cases team who show this flyout when an alert is clicked.