[Cloud Posture] add resource findings table #131334
Conversation
|
@orouz can you please update the |
@tinnytintin10 should this change affect both |
yes, it should be reflected on both. ty! |
orouz
force-pushed
the
resource_findings_table
branch
from
455d1de to
645b8c5
Compare
orouz
force-pushed
the
resource_findings_table
branch
from
645b8c5 to
4ece26a
Compare
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
| const columns: [ | ||
| EuiTableActionsColumnType<CspFinding>, | ||
| ...Array<EuiBasicTableColumn<CspFinding>> | ||
| ] = useMemo( | ||
| () => [getExpandColumn<CspFinding>({ onClick: setSelectedFinding }), ...getFindingsColumns()], |
There was a problem hiding this comment.
changed because columns are partially shared (for now) between group-by-none and resource-findings
| query: { | ||
| ...query, | ||
| bool: { | ||
| ...query?.bool, | ||
| filter: [...(query?.bool?.filter || []), { term: { 'resource_id.keyword': resourceId } }], | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
this is where we say this query is limited to a resourceId
might change this later to just be merge(a,b) to read nicer
orouz
added
release_note:skip
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security Posture) |
| width: '40px', | ||
| actions: [ | ||
| { | ||
| name: 'Expand', |
There was a problem hiding this comment.
should be localized (both name and description)
There was a problem hiding this comment.
i think it's OK to merge as is and fix this in the next PR which is rebased on this one, and i'd like to rebase it on upstream
There was a problem hiding this comment.
Summary
this PR adds the table component for the
/findings/resource/:resourceIdroute.it includes:
group_by_noneeswith hidden filter forresource_id: resourceIdDemo
Screen.Recording.2022-05-02.at.18.08.18.mov
Checklist
Delete any items that are not applicable to this PR.