-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Explain log rate spikes: Plugin setup #131317
Conversation
3a59a4c
to
782d13e
Compare
x-pack/plugins/ml/public/application/aiops/explain_log_rate_spikes.tsx
Outdated
Show resolved
Hide resolved
* This is an internal hard coded feature flag so we can easily turn on/off the | ||
* "Explain log rate spikes UI" during development until the first release. | ||
*/ | ||
export const AIOPS_ENABLED = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you set this to false
before merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, we'll leave it as true
for now for easier internal testing and will switch to false
right before feature freeze.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and overall looks good. Just left a few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example stream API tests LGTM with just one observation.
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @walterra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM ⚡ Thanks for your work on this!! 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest changes LGTM
Summary
Part of #136265.
Resolves #131607.
Sets up the boilerplate code for the
aiops
plugin and adds a demo page within the ML app to demonstrate single API request data streaming from Kibana server to UI client.data_visualizer
plugin code.Review note for
kibana-operations
: This touchespackages/kbn-optimizer/limits.yml
for the newaiops
plugin to set an initial KB limit, looking atCODEOWNERS
, I think that's the only file that triggered the review request.Plugin page is available at this Kibana URL: http://localhost:5601/app/ml/aiops/explain_log_rate_spikes
The streaming demo shows a bar chart race:
Checklist
For maintainers