[Unified Search] Show error message for invalid date filter value #131290

nlatipov · 2022-04-30T21:38:47Z

Summary

Motivation:

When adding a filter for a dashboard that requires a date format value (e.g., @timestamp field), there is no field error message in the UI indicating why the input is invalid.

What was done:

Added fields isInvalid and error to show errors in EuiFormRow;
Moved the logic of determining the validity to a separate function getFieldValidityAndErrorMessage;
Added unit tests for getFieldValidityAndErrorMessage;
Added i18n for the text of the error message Invalid date format provided;

…ssage-for-not-valid-date

nlatipov · 2022-05-05T09:46:53Z

@elasticmachine merge upstream

…/github.com/elastic/kibana into issue-show-error-message-for-not-valid-date

elasticmachine · 2022-05-05T17:22:20Z

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

…ssage-for-not-valid-date

stratoula

This works ok but there is a bad behavior when I am trying to edit a date filter. Check here how the focus is lost from the input, it makes it very difficult to change the value.

x-pack/plugins/translations/translations/ja-JP.json

src/plugins/unified_search/public/utils/helpers.ts

alexwizp · 2022-05-13T09:38:38Z

src/plugins/unified_search/public/utils/helpers.ts

+import { isEmpty } from 'lodash';
+import { validateParams } from '../filter_bar/filter_editor/lib/filter_editor_utils';
+
+export const getFieldValidityAndErrorMessage = (


@stratoula, @ppisljar I'm surprised we don't have validation for input values for KBN_FIELD_TYPES. Might make sense to define it in the kbn-field-types package or anywhere else to reuse it in the future

i agree this is possible update for the future if we find a need for such utility in other places

cc @mattkime

src/plugins/unified_search/public/utils/helpers.ts

src/plugins/unified_search/public/filter_bar/filter_item/filter_item.tsx

nlatipov · 2022-05-13T10:53:47Z

@elasticmachine merge upstream

…/github.com/elastic/kibana into issue-show-error-message-for-not-valid-date

src/plugins/unified_search/public/utils/helpers.ts

nlatipov · 2022-05-16T06:37:26Z

@elasticmachine merge upstream

ppisljar

code LGTM

stratoula

LGTM! I tested it and now it works fine!

kibana-ci · 2022-05-17T09:58:56Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`unifiedSearch`	192	193	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`unifiedSearch`	175.8KB	176.3KB	+536.0B

Unknown metric groups

References to deprecated APIs

id	before	after	diff
`unifiedSearch`	253	265	+12

History

💚 Build #44768 succeeded f818481
💚 Build #44666 succeeded 0adb50e
💚 Build #44659 succeeded eb9f99d
💚 Build #44651 succeeded ee0ce4e
💚 Build #43654 succeeded 7e1f26b
💚 Build #43561 succeeded 81bd1f3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nlatipov

…astic#131290) * feat: added show error message for invalid date * refact: move logic in HOC * feat: refactoring code and added translation * refact show error * refact: show error message * refact: remove translation * refactor: changed menu for show FilterEdit * fix: open/close popover * feat: field.type => KBN_FIELD_TYPES * feat: remove extra code with with input check and refactored filter item * feat: added tests and refactoring code * refact: getFieldValidityAndErrorMessage * feat: return isInvalid checking in valur input type for string, ip

* wip I * add alert table state in case * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * add new API to get FeatureID form registrationContext and update UI to use this new API * rm dead code * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * remove unnecessary memo * adds tests for case view helpers * Move http call to API and add tests for getFeatureIds * fix type + unit test * add unit tests + cleanup * add new api integration test for _feature_ids * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Fix small type creating typescript slowness * remove console log * use import type for validfeatureId * force any to improve typescript performance * Update APM (#132270) Co-authored-by: Renovate Bot <[email protected]> * [ResponseOps][Docs] Updating ServiceNow docs with OAuth setup instructions (#131344) * Updating ServiceNow docs. Need screenshots * Adding screenshots * Fix nested screenshots and lists * Tweaks and screenshots * Updates * blergh * Apply suggestions from code review Co-authored-by: Lisa Cawley <[email protected]> * Apply suggestions from code review Co-authored-by: Mike Côté <[email protected]> Co-authored-by: lcawl <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Mike Côté <[email protected]> * Show polling options when 'Data streams' option is selected in the Console Settings modal. (#132277) * [Osquery] Make Osquery All with All base privillege (#130523) * [XY] Add normalizeTable function to correct works with esdocs (#131917) * Add normalizeTable function to correct works with esdocs * Fix types * Fix types * Fix CI * Fix CI * Some fixes * Remove fallback with min/max value for domain * Added tests * Some refactoring Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Yaroslav Kuznietsov <[email protected]> * [Osquery] Add default osquery_saved_query objects (#129461) * [Unified Search] Show error message for invalid date filter value (#131290) * feat: added show error message for invalid date * refact: move logic in HOC * feat: refactoring code and added translation * refact show error * refact: show error message * refact: remove translation * refactor: changed menu for show FilterEdit * fix: open/close popover * feat: field.type => KBN_FIELD_TYPES * feat: remove extra code with with input check and refactored filter item * feat: added tests and refactoring code * refact: getFieldValidityAndErrorMessage * feat: return isInvalid checking in valur input type for string, ip * Update navigation landing pages to use appLinks config (#132027) * Update navigation landing pages to use appLinks config * Please code review * align app links changes * Update links descriptions * Rollback title changes * Fix wrong links descriptions * Fix unit tests * Fix description Co-authored-by: semd <[email protected]> * [Cloud Posture] add resource findings page flyout (#132243) * [Discover] Add a tour for Document Explorer (#131125) * [Discover] Add "Take a tour" button to the Document Explorer callout * [Discover] Tmp * [Discover] Add a first Document Explorer tour step * [Discover] Add other Document Explorer tour steps * [Discover] Update tour steps positioning * [Discover] Add gifs to tour steps * [Discover] Refactor how tour steps are registered * [Discover] Add new step to the tour. Update tour steps text. * [Discover] Improve steps positioning * [Discover] Fix positioning for Add field step * [Discover] Add icons to tour steps * [Discover] Reorganize components * [Discover] Skip Columns step when it's not available * [Discover] Rename components * [Discover] Add some tests * [Discover] Fix positioning * [Discover] Fix props * [Discover] Render steps only if the tour is active * [Discover] Update gifs * [Discover] Add image alt text for gifs * [Discover] Tag the Take tour button * [Discover] Update text and tests * [Discover] Add more tests * [Discover] Rename assets directory * [Discover] Fix tour in mobile view. Improve steps positioning and animation. * [Discover] Update text in tour steps * [Discover] Update sort.gif * [Discover] Update image width * Update src/plugins/discover/public/components/discover_tour/discover_tour_provider.tsx Co-authored-by: gchaps <[email protected]> * Update src/plugins/discover/public/components/discover_tour/discover_tour_provider.tsx Co-authored-by: gchaps <[email protected]> * [Discover] Update sort.gif * [Discover] Fix code style Co-authored-by: gchaps <[email protected]> Co-authored-by: Kibana Machine <[email protected]> * [XY] Add `minTimeBarInterval` arg (#128726) * Added `xAxisInterval` arg * Add validation * Add tests * Rename xAxisInterval to minTimeBarInterval and add validation * Fix imports * Add tests to validation * Fix conflicts * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * Fix tests Co-authored-by: Kibana Machine <[email protected]> * do not use barrel imports * do not use barrel import * do not use barrel import * do not use barrel imports * do not use barrel import * import types * Add tests * Fix cases bundle size * Add more tests * [Fleet] Add new API to get current upgrades (#132276) * Add support of Data View switching for Agg-Based visualizations (#132184) * Add support of Data View switching for Agg-Based visualizations * fix CI * add use_date_view_updates * implement sync with state * cleanup * cleanup * cleanup * Update index.ts * fix PR comments * Update use_data_view_updates.ts * Update use_data_view_updates.ts Co-authored-by: Kibana Machine <[email protected]> * [Security Solution] Responsive styling fixes (#131951) * [Discover] Add Analytics No Data Page (#131965) * [Discover] Add Analytics No Data Page * Make showEmptyPrompt parameter optional * Remove unused import * Remove unnecessary test * Fix test * Update failing test? * Update failing test * Changing the order of functional tests * Fix error handling * Addressing PR comments Co-authored-by: Kibana Machine <[email protected]> * Remove barrel export from public index file * remove barrel export * Re-export missing exports * Turn off feature flag Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Esteban Beltran <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Ying Mao <[email protected]> Co-authored-by: lcawl <[email protected]> Co-authored-by: Mike Côté <[email protected]> Co-authored-by: CJ Cenizal <[email protected]> Co-authored-by: Tomasz Ciecierski <[email protected]> Co-authored-by: Uladzislau Lasitsa <[email protected]> Co-authored-by: Yaroslav Kuznietsov <[email protected]> Co-authored-by: Nodir Latipov <[email protected]> Co-authored-by: Pablo Machado <[email protected]> Co-authored-by: semd <[email protected]> Co-authored-by: Or Ouziel <[email protected]> Co-authored-by: Julia Rechkunova <[email protected]> Co-authored-by: gchaps <[email protected]> Co-authored-by: Christos Nasikas <[email protected]> Co-authored-by: Nicolas Chaulet <[email protected]> Co-authored-by: Alexey Antonov <[email protected]> Co-authored-by: Steph Milovic <[email protected]> Co-authored-by: Maja Grubic <[email protected]>

feat: added show error message for invalid date

3e4fefa

nlatipov self-assigned this Apr 30, 2022

nlatipov added Feature:Unified search Unified search related tasks Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.3.0 labels Apr 30, 2022

nlatipov changed the title ~~feat: added show error message for invalid date~~ [Unified Search] Show error message for invalid date filter value Apr 30, 2022

Merge remote-tracking branch 'upstream/main' into issue-show-error-me…

dcfd92d

…ssage-for-not-valid-date

kibanamachine and others added 6 commits May 5, 2022 04:46

Merge branch 'main' into issue-show-error-message-for-not-valid-date

39bdbac

refact: move logic in HOC

fd8e60a

feat: refactoring code and added translation

da39502

Merge branch 'issue-show-error-message-for-not-valid-date' of https:/…

77c09e7

…/github.com/elastic/kibana into issue-show-error-message-for-not-valid-date

refact show error

2d9603d

refact: show error message

03f418f

nlatipov requested a review from stratoula May 5, 2022 17:19

nlatipov marked this pull request as ready for review May 5, 2022 17:22

nlatipov requested a review from a team as a code owner May 5, 2022 17:22

Merge remote-tracking branch 'upstream/main' into issue-show-error-me…

81bd1f3

…ssage-for-not-valid-date

nlatipov force-pushed the issue-show-error-message-for-not-valid-date branch from 833829e to 81bd1f3 Compare May 10, 2022 07:35

stratoula reviewed May 10, 2022

View reviewed changes

x-pack/plugins/translations/translations/ja-JP.json Outdated Show resolved Hide resolved

src/plugins/unified_search/public/utils/helpers.ts Show resolved Hide resolved

refact: remove translation

7e1f26b

nlatipov requested a review from alexwizp May 12, 2022 10:17

nlatipov added 2 commits May 13, 2022 13:40

refactor: changed menu for show FilterEdit

f31ab67

fix: open/close popover

ee0ce4e

alexwizp reviewed May 13, 2022

View reviewed changes

src/plugins/unified_search/public/utils/helpers.ts Outdated Show resolved Hide resolved

alexwizp reviewed May 13, 2022

View reviewed changes

src/plugins/unified_search/public/utils/helpers.ts Outdated Show resolved Hide resolved

alexwizp reviewed May 13, 2022

View reviewed changes

src/plugins/unified_search/public/filter_bar/filter_item/filter_item.tsx Outdated Show resolved Hide resolved

alexwizp reviewed May 13, 2022

View reviewed changes

src/plugins/unified_search/public/filter_bar/filter_item/filter_item.tsx Outdated Show resolved Hide resolved

nlatipov added 2 commits May 13, 2022 15:31

feat: field.type => KBN_FIELD_TYPES

50b9ad8

feat: remove extra code with with input check and refactored filter item

099c270

kibanamachine and others added 3 commits May 13, 2022 05:53

Merge branch 'main' into issue-show-error-message-for-not-valid-date

ed3993b

feat: added tests and refactoring code

4bdd6d2

Merge branch 'issue-show-error-message-for-not-valid-date' of https:/…

eb9f99d

…/github.com/elastic/kibana into issue-show-error-message-for-not-valid-date

alexwizp reviewed May 13, 2022

View reviewed changes

src/plugins/unified_search/public/utils/helpers.ts Outdated Show resolved Hide resolved

alexwizp reviewed May 13, 2022

View reviewed changes

src/plugins/unified_search/public/utils/helpers.ts Outdated Show resolved Hide resolved

refact: getFieldValidityAndErrorMessage

05e1984

nlatipov requested a review from alexwizp May 13, 2022 13:45

feat: return isInvalid checking in valur input type for string, ip

0adb50e

Merge branch 'main' into issue-show-error-message-for-not-valid-date

f818481

ppisljar approved these changes May 17, 2022

View reviewed changes

Merge branch 'main' into issue-show-error-message-for-not-valid-date

7509c2a

stratoula approved these changes May 17, 2022

View reviewed changes

nlatipov merged commit a81b7c8 into main May 17, 2022

nlatipov deleted the issue-show-error-message-for-not-valid-date branch May 17, 2022 10:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Unified Search] Show error message for invalid date filter value #131290

[Unified Search] Show error message for invalid date filter value #131290

nlatipov commented Apr 30, 2022 •

edited

Loading

nlatipov commented May 5, 2022

elasticmachine commented May 5, 2022

stratoula left a comment •

edited

Loading

alexwizp May 13, 2022

ppisljar May 17, 2022

ppisljar May 17, 2022

nlatipov commented May 13, 2022

nlatipov commented May 16, 2022

ppisljar left a comment

stratoula left a comment

kibana-ci commented May 17, 2022

References to deprecated APIs

[Unified Search] Show error message for invalid date filter value #131290

[Unified Search] Show error message for invalid date filter value #131290

Conversation

nlatipov commented Apr 30, 2022 • edited Loading

Summary

nlatipov commented May 5, 2022

elasticmachine commented May 5, 2022

stratoula left a comment • edited Loading

Choose a reason for hiding this comment

alexwizp May 13, 2022

Choose a reason for hiding this comment

ppisljar May 17, 2022

Choose a reason for hiding this comment

ppisljar May 17, 2022

Choose a reason for hiding this comment

nlatipov commented May 13, 2022

nlatipov commented May 16, 2022

ppisljar left a comment

Choose a reason for hiding this comment

stratoula left a comment

Choose a reason for hiding this comment

kibana-ci commented May 17, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

References to deprecated APIs

History

nlatipov commented Apr 30, 2022 •

edited

Loading

stratoula left a comment •

edited

Loading