[Cloud Security]Update package name #131137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CohenIdo
added
release_note:skip
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
eyalkraft
approved these changes
May 1, 2022
kfirpeled
approved these changes
May 1, 2022
|
|
||
| export const AGENT_LOGS_INDEX_PATTERN = '.logs-cis_kubernetes_benchmark.metadata*'; | ||
| export const AGENT_LOGS_INDEX_PATTERN = '.logs-cloud_security_posture.metadata*'; |
| @@ -65,7 +65,7 @@ export const createIndexIfNotExists = async ( | |||
| } | |||
| } catch (err) { | |||
| const error = transformError(err); | |||
| logger.error(`Failed to create ${LATEST_FINDINGS_INDEX_PATTERN}`); | |||
| logger.error(`Failed to create ${LATEST_FINDINGS_INDEX_DEFAULT_NS}`); | |||
There was a problem hiding this comment.
should use indexName / indexPattern
There was a problem hiding this comment.
rename indexName to indexTemplateName
kfirpeled
reviewed
May 1, 2022
Comment on lines
+39
to
42
| if (packagePolicies[0].package?.name !== CLOUD_SECURITY_POSTURE_PACKAGE_NAME) { | ||
| // TODO: improve this validator to support any future CSP package | ||
| throw new Error(`Package Policy Id '${packagePolicyId}' is not CSP package`); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (packagePolicies[0].package?.name !== CLOUD_SECURITY_POSTURE_PACKAGE_NAME) { | |
| // TODO: improve this validator to support any future CSP package | |
| throw new Error(`Package Policy Id '${packagePolicyId}' is not CSP package`); | |
| } | |
| if (packagePolicies[0].package?.name !== CLOUD_SECURITY_PACKAGE_NAME) { | |
| throw new Error( | |
| `Package Policy Id '${packagePolicyId}' is not of type cloud security posture package` | |
| ); |
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.