Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates esArchiver mappings to use single type #13107

Merged
merged 1 commit into from
Jul 25, 2017

Conversation

tylersmalley
Copy link
Contributor

No description provided.

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalger spalger merged commit 460157d into elastic:master Jul 25, 2017
spalger pushed a commit that referenced this pull request Jul 25, 2017
Signed-off-by: Tyler Smalley <[email protected]>(cherry picked from commit 460157d)
@spalger
Copy link
Contributor

spalger commented Jul 25, 2017

5.6: cc54853 reverted in 4b53e26

spalger added a commit that referenced this pull request Jul 25, 2017
@spalger spalger removed the v5.6.0 label Jul 25, 2017
@epixa
Copy link
Contributor

epixa commented Jul 26, 2017

@tylersmalley @spalger This needs to go into 6.x and 6.0 as well, right?

@epixa
Copy link
Contributor

epixa commented Jul 26, 2017

Also, this does appear to have a test failure in the esarchivers tests, but the test job is still turning out green:

✖ fail: "tests "before all" hook"
     │          │        [mapper_parsing_exception] No type specified for field [_default_]

Search for fail: in the intake console for all the details. We really need to figure out what the hell is going on with this esarchiver test stuff... I have no idea how this stuff is failing while still passing intake.

@tylersmalley
Copy link
Contributor Author

I will have a PR up shortly to resolve the test.

@spalger, it appears the esArchiver exception is being absorbed by the log.

tylersmalley added a commit that referenced this pull request Jul 26, 2017
tylersmalley added a commit that referenced this pull request Jul 26, 2017
@tylersmalley
Copy link
Contributor Author

6.0: b0c4a6a
6.1/6.x: 4d8120d

@tylersmalley
Copy link
Contributor Author

Follow-up PR: #13122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants