[Security Solution][Endpoint][EventFilters] Port Event Filters to use ArtifactListPage component

[ashokaditya]

Summary

Refactors endpoint event filters page to use ArtifactListPage

Checklist

Delete any items that are not applicable to this PR.

• Unit or functional tests were updated or added to match the most common scenarios

[kevinlog]

checked it out and tried it and everything looks to be working!

I can add Event Filters from both the page in Management and in the Events list:

I can perform management actions in the Policy page and Management page

Manifests are still building correctly and policies are updated

[kevinlog]

this approval is for functionality upon checking out the PR and running it. Will leave the code comments to the other devs

[dasansol92]

This looks awesome! A lot of new awesome code and very good cleaning stuff! Thanks for doing all of this. I let you some comments/questions/suggestions, let me know what do you think 🙂

[dasansol92]

Should we move these tests to the effect scope ones here?

[ashokaditya]

Good idea. Although, there are a similar set of tests also in TA form. I think let's leave it here for now and refactor the tests when we extract common form elements into one component.

[dasansol92]

What about having this as a default value of the exception? For example, having the eventFilter as state instead of being a useMemo, so you can define the default value when creating it with the existing comments:

const [eventFilter, setEventFilter] = useState(exception);

[ashokaditya]

Yeah, I tried that earlier when I got started with the form but that doesn't work . The AddExceptionComments expects the exception item comments to also have updated_by, created_by keys that the form added comments do not have.

Thus, I went with this approach where we pick out the saved comments once on the initial render and do not update it until the event filter is created with new comments.

[dasansol92]

this function name got me confused, why processChanged? Can we change it by something with event or exception?

Also, if you decide to have the exception in a state, you could just setException({...changes}) and then have a useEffect to call onChange every time exception change.

[ashokaditya]

I see. I went with this particular name cause I want to process/compute any changes that happened with the exception. This is also named notifyOfChange in other forms I think. We can agree on a single name and keep it consistent in all the forms.

[michaelolo24]

Investigations code owner file changes. LGTM!

[dasansol92]

Awesome! Thanks for all the effort here 🚢
Would you mind adding a FTR here for event filters? It can be done in another pr if you want 🙂

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 13a2df1
• Storybooks Preview
• Webpack Bundle Analyzer

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
securitySolution	2936	2926	-10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
securitySolution	5.0MB	5.0MB	-14.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
securitySolution	247.1KB	247.1KB	-6.0B

History

• 💔 Build #46053 failed 836a83c
• 💔 Build #46015 failed 4dd3828e3982383e74e007993d950b76f0cf21af
• 💚 Build #45999 succeeded 54a731d
• 💚 Build #45656 succeeded 32bb2bd
• 💔 Build #45592 failed 07134c6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ashokaditya