Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests the verify correct dataType in jQuery.ajax request when loading Console app state. #13092

Merged
merged 1 commit into from
Jul 27, 2017

Conversation

azasypkin
Copy link
Member

@azasypkin azasypkin commented Jul 25, 2017

To make sure we're safe with jQuery 2.2.4 and https://nodesecurity.io/advisories/328.

Tests are written in a "new style" (not QUnit) so that we can run them on CI.

@azasypkin azasypkin added Feature:Console Dev Tools Console Feature test labels Jul 25, 2017
@azasypkin azasypkin requested a review from tylersmalley July 25, 2017 10:53
kbnXsrfToken: false
});

sinon.assert.calledTwice(inputMock.moveToNextRequestEdge);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: it's a bit weird that it's called twice (not sure if it's a bug or not), but here is how it works :)

@azasypkin
Copy link
Member Author

jenkins, test this

@tylersmalley
Copy link
Contributor

Try merging master into your branch

@azasypkin azasypkin force-pushed the issue-xxx-jquery-xss-test branch from 1937896 to 85b882d Compare July 26, 2017 06:15
@azasypkin
Copy link
Member Author

Try merging master into your branch

Done, build is green now. By the way is there any reason why we don't want to use let's say karma-mocha-reporter as karma reporter and use dots and progress instead? It seems dots and progress don't print test name to the console/log, but sometimes it's nice to know for sure that your test has been run.

@tylersmalley
Copy link
Contributor

I wouldn't be opposed to using the mocha reporter if it added value.

Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azasypkin
Copy link
Member Author

I wouldn't be opposed to using the mocha reporter if it added value.

Ok, I'll add it to my TODO list then.

@azasypkin azasypkin merged commit 2bee8bb into elastic:master Jul 27, 2017
@azasypkin azasypkin deleted the issue-xxx-jquery-xss-test branch July 27, 2017 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Console Dev Tools Console Feature test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants