-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests the verify correct dataType
in jQuery.ajax
request when loading Console app state.
#13092
Conversation
kbnXsrfToken: false | ||
}); | ||
|
||
sinon.assert.calledTwice(inputMock.moveToNextRequestEdge); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: it's a bit weird that it's called twice (not sure if it's a bug or not), but here is how it works :)
jenkins, test this |
Try merging master into your branch |
… when loading Console app state.
1937896
to
85b882d
Compare
Done, build is green now. By the way is there any reason why we don't want to use let's say |
I wouldn't be opposed to using the mocha reporter if it added value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ok, I'll add it to my TODO list then. |
To make sure we're safe with
jQuery 2.2.4
and https://nodesecurity.io/advisories/328.Tests are written in a "new style" (not
QUnit
) so that we can run them on CI.