[eslint-config-kibana] Add jest plugin and settings #13090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weltenwort
added
Team:Core
kimjoar
reviewed
Jul 25, 2017
| @@ -22,6 +22,7 @@ | |||
| "eslint": "^4.1.0", | |||
| "eslint-plugin-babel": "^4.1.1", | |||
| "eslint-plugin-import": "^2.6.0", | |||
| "eslint-plugin-jest": "^20.0.3", | |||
There was a problem hiding this comment.
This will always require the jest eslint plugin be installed, but I think that's okey. I don't see any harm in people not using Jest having to install this, as this works great for Kibana and xpack.
There was a problem hiding this comment.
Aren't peer dependencies always considered optional?
There was a problem hiding this comment.
Ah, yeah, you'll just receive the warning
kimjoar
approved these changes
Jul 25, 2017
|
@spalger does this look good to you? |
weltenwort
force-pushed
the
enhancement/add-shared-eslint-jest-config
branch
from
88b34e0 to
02c79bc
Compare
cjcenizal
approved these changes
Jul 26, 2017
weltenwort
force-pushed
the
enhancement/add-shared-eslint-jest-config
branch
2 times, most recently
from
42d3724 to
c3ed527
Compare
This extracts the ui-specific eslint settings from elastic/kibana so they can be applied to other repositories as well.
weltenwort
force-pushed
the
enhancement/add-shared-eslint-jest-config
branch
from
c3ed527 to
e78698d
Compare
cjcenizal
pushed a commit
to cjcenizal/kibana
that referenced
this pull request
Aug 3, 2017
cjcenizal
added a commit
that referenced
this pull request
Aug 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extracts the jest-specific eslint settings from Kibana's
.eslintrcinto theeslint-config-kibanapackage so they can be applied to projects living in other repositories as well.replaces elastic/eslint-config-kibana#9