Remove @elastic folder from packages/
#13089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
added
Team:Operations
|
Just a note that we'll need to backport this to 6.x. |
|
👍 |
|
jenkins, test it |
jbudz
approved these changes
Jul 31, 2017
|
I'm on vacation for the next three weeks, so if anyone wants to merge and backport, just go ahead. Otherwise I'll get to it when I'm back from vacation :) |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hm, looks like I forgot about the
packages/@elasticfolder when merging #12725. Instead of moving the eslint-config-kibana under@elasticI suggest keeping all our packages directly underpackages/instead (all our packages should be pushed to@elasticeither way).