Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vega] fix requesting not permitted or used data views #130878

Merged
merged 4 commits into from
May 3, 2022
Merged

[Vega] fix requesting not permitted or used data views #130878

merged 4 commits into from
May 3, 2022

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Apr 25, 2022 •
edited
Loading

Summary

Analogical solution to the TSVB #130033
Steps to reproduce:

  1. Create an index by dev tools:
PUT /kibana_sample_data_flights2
  1. Open a Vega visualization based on kibana_sample_data_flights. In the network tab, you'll see a request also to kibana_sample_data_flights2.

Expected behavior: Only exact match should be taken into account. This PR fixes it.

@mbondyra mbondyra requested a review from a team as a code owner April 25, 2022 11:23
@mbondyra mbondyra added release_note:fix Feature:Vega Vega visualizations Team:Visualizations Visualization editors, elastic-charts and infrastructure auto-backport Deprecated - use backport:version if exact versions are needed v8.3.0 v8.2.1 v7.17.4 labels Apr 25, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@mbondyra
Copy link
Contributor Author

@elasticmachine merge upstream

@mbondyra mbondyra enabled auto-merge (squash) April 25, 2022 14:41
@mbondyra mbondyra disabled auto-merge April 25, 2022 14:42
@mbondyra
Copy link
Contributor Author

mbondyra commented May 2, 2022

@elasticmachine merge upstream

@mbondyra
Copy link
Contributor Author

mbondyra commented May 2, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visTypeVega 1.7MB 1.7MB +4.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypeVega 33.2KB 33.2KB +2.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

stratoula
stratoula approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, I tested it locally in Chrome and only the exact dataview is sent now :)

@mbondyra mbondyra merged commit 98041ca into elastic:main May 3, 2022
@mbondyra mbondyra deleted the vega/data_view_find_fix branch May 3, 2022 07:07
kibanamachine pushed a commit that referenced this pull request May 3, 2022
@mbondyra
[Vega] fix requesting not permitted or used data views (#130878)
0e92e65 
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 98041ca)
@kibanamachine kibanamachine mentioned this pull request May 3, 2022
Merged
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
✅ 8.2
❌ 7.17 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 130878

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 3, 2022
@kibanamachine @mbondyra
[Vega] fix requesting not permitted or used data views (#130878) (#13…
f0b6ce3 
…1367)

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 98041ca)

Co-authored-by: Marta Bondyra <[email protected]>
@mbondyra mbondyra mentioned this pull request May 3, 2022
Merged
mbondyra added a commit to mbondyra/kibana that referenced this pull request May 3, 2022
@mbondyra
[Vega] fix requesting not permitted or used data views (elastic#130878)
c5040fc 
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 98041ca)

# Conflicts:
#	src/plugins/vis_types/vega/public/lib/extract_index_pattern.ts
#	src/plugins/vis_types/vega/public/vega_view/vega_base_view.js
mbondyra added a commit that referenced this pull request May 3, 2022
@mbondyra @kibanamachine
[7.17] [Vega] fix requesting not permitted or used data views (#130878)…
2577520 
… (#131392)

* [Vega] fix requesting not permitted or used data views (#130878)

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 98041ca)

# Conflicts:
#	src/plugins/vis_types/vega/public/lib/extract_index_pattern.ts
#	src/plugins/vis_types/vega/public/vega_view/vega_base_view.js

* Update src/plugins/vis_types/vega/public/vega_view/vega_base_view.js

Co-authored-by: Kibana Machine <[email protected]>
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
@mbondyra @kibanamachine @kertal
[Vega] fix requesting not permitted or used data views (elastic#130878)
d767143 
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexwizp alexwizp alexwizp approved these changes

@stratoula stratoula stratoula approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Vega Vega visualizations release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.17.4 v8.2.1 v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mbondyra @elasticmachine @kibana-ci @kibanamachine @stratoula @alexwizp