Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.2.1][8.3][Session View] Add tooltip to session view details panel values #130829

Merged
merged 2 commits into from
Apr 25, 2022

Conversation

zizhouW
Copy link

@zizhouW zizhouW commented Apr 21, 2022

Summary

Show tooltip on hover session view details panel item values

image

@zizhouW zizhouW added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.3.0 Team: AWP: Visualization AWP team that does most fullstack work in kibana labels Apr 21, 2022
@zizhouW zizhouW requested a review from a team April 21, 2022 20:06
@zizhouW zizhouW self-assigned this Apr 21, 2022
@@ -30,10 +22,15 @@ export const useStyles = () => {
paddingLeft: euiTheme.size.xs,
};

const ellipsis: CSSObject = {
overflow: 'hidden',
textOverflow: 'ellipsis',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need to add whiteSpace: 'nowrap', as well?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea seems like in this case having whiteSpace: 'nowrap' on the parent level (tooltip anchor) was enough
image

@zizhouW
Copy link
Author

zizhouW commented Apr 25, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
sessionView 61.4KB 61.1KB -330.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @zizhouW

@zizhouW zizhouW merged commit 6d9a7ce into elastic:main Apr 25, 2022
@zizhouW zizhouW changed the title [8.3][Session View] Add tooltip to session view details panel values [8.2.1][8.3][Session View] Add tooltip to session view details panel values May 3, 2022
@zizhouW zizhouW added v8.2.1 auto-backport Deprecated - use backport:version if exact versions are needed and removed backport:skip This commit does not require backporting labels May 3, 2022
kibanamachine pushed a commit that referenced this pull request May 3, 2022
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 6d9a7ce)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

zizhouW pushed a commit that referenced this pull request May 3, 2022
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 6d9a7ce)

Co-authored-by: Jack <[email protected]>
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team: AWP: Visualization AWP team that does most fullstack work in kibana v8.2.1 v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security Solution] Long values should be truncated and tooltip must show
4 participants