[Security Solution] [Investigations] [Tech Debt] removes deepEqual checks in column headers and data providers #130740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-goldstein
added
release_note:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
kqualters-elastic
approved these changes
Apr 20, 2022
janmonschke
approved these changes
Apr 21, 2022
|
@elasticmachine merge upstream |
…l` checks in column headers and data providers This tech debt PR is another entry in a series to remove `React.memo` `deepEqual` checks, per the details in <elastic#124151> - It removes `deepEqual` checks in Timeline's column headers and data providers - Files made redundant by the `timelines` plugin adopting `EuiDataGrid` are deleted ### Methodology The following techniques were used to ensure that removing the `deepEqual` checks did NOT result in unexpected re-renders: - To understand why components re-rendered, Timeline was profiled with the `Record why each component rendered wile profiling` setting in the React dev tools Profiler enabled, shown in the (illustrative) screenshot below:  - Components were temporarily instrumented with counters that incremented every time the component was rendered. Log statements prefixed with `[pre]` were observed before making changes, per the screenshot below:  - After removing the `deepEqual` checks, the log prefix was updated to `[POST]`, per the screenshot below:  The `[pre]` and `[POST]` counters were compared to verify removing the `deepEqual` checks did NOT introduce unexpected re-renders.
andrew-goldstein
force-pushed
the
remove-column-header-and-providers-deep-equal
branch
from
f71f7ed to
dff43b2
Compare
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
andrew-goldstein
deleted the
remove-column-header-and-providers-deep-equal
branch
andrew-goldstein
added a commit
to andrew-goldstein/kibana
that referenced
this pull request
Apr 25, 2022
… code from timelines plugin This follow-up PR removes redundant code from the `timelines` plugin, identified while implementing elastic#130740
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
May 24, 2022
…ecks in column headers and data providers (elastic#130740) ## [Security Solution] [Investigations] [Tech Debt] removes `deepEqual` checks in column headers and data providers This tech debt PR is another entry in a series to remove `React.memo` `deepEqual` checks, per the details in <elastic#124151> - It removes `deepEqual` checks in Timeline's column headers and data providers - Files made redundant by the `timelines` plugin adopting `EuiDataGrid` are deleted ### Methodology The following techniques were used to ensure that removing the `deepEqual` checks did NOT result in unexpected re-renders: - To understand why components re-rendered, Timeline was profiled with the `Record why each component rendered wile profiling` setting in the React dev tools Profiler enabled, shown in the (illustrative) screenshot below:  - Components were temporarily instrumented with counters that incremented every time the component was rendered. Log statements prefixed with `[pre]` were observed before making changes, per the screenshot below:  - After removing the `deepEqual` checks, the log prefix was updated to `[POST]`, and the log entries were observed again, per the screenshot below:  The `[pre]` and `[POST]` counters were compared to verify removing the `deepEqual` checks did NOT introduce unexpected re-renders.
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
May 24, 2022
…de from timelines plugin (elastic#130928) ## [Security Solution] [Investigations] [Tech Debt] removes redundant code from the timelines plugin This follow-up PR removes redundant code from the `timelines` plugin, identified while implementing elastic#130740
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Security Solution] [Investigations] [Tech Debt] removes
deepEqualchecks in column headers and data providersThis tech debt PR is another entry in a series to remove
React.memodeepEqualchecks, per the details in #124151deepEqualchecks in Timeline's column headers and data providerstimelinesplugin adoptingEuiDataGridare deletedMethodology
The following techniques were used to ensure that removing the
deepEqualchecks did NOT result in unexpected re-renders:Record why each component rendered wile profilingsetting in the React dev tools Profiler enabled, shown in the (illustrative) screenshot below:[pre]were observed before making changes, per the screenshot below:deepEqualchecks, the log prefix was updated to[POST], and the log entries were observed again, per the screenshot below:The
[pre]and[POST]counters were compared to verify removing thedeepEqualchecks did NOT introduce unexpected re-renders.