Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Posture] Package name refactored to cloud_security_posture #130435

Closed

Conversation

kfirpeled
Copy link
Contributor

Summary

This pr is part of a larger change to rename the current integration/ package name of cis_kubernetes_benchmark to cloud_security_posture, as it will contain more benchmarks in the future and should have a proper naming.

Checkout also elastic/integrations#3113

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@kfirpeled kfirpeled added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Cloud Security Cloud Security team related v8.3.0 labels Apr 17, 2022
@kfirpeled kfirpeled requested a review from a team April 17, 2022 10:01
@kfirpeled kfirpeled changed the title [Cloud Posture] Package name renamted to cloud_security_posture [Cloud Posture] Package name refactored to cloud_security_posture Apr 17, 2022
@kfirpeled kfirpeled force-pushed the migrate_cis_k8s_benchmark_package branch from 12cea75 to 03f8587 Compare April 20, 2022 14:26
@kibana-ci
Copy link
Collaborator

kibana-ci commented Apr 20, 2022

💔 Build Failed

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 407.2KB 407.2KB -23.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kfirpeled kfirpeled closed this May 1, 2022
@kfirpeled kfirpeled deleted the migrate_cis_k8s_benchmark_package branch May 1, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants