Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Task Manager's managed configuration integration jest test #130331

Merged
merged 2 commits into from
Apr 18, 2022
Merged

Fix Task Manager's managed configuration integration jest test #130331

merged 2 commits into from
Apr 18, 2022

Conversation

mikecote
Copy link
Contributor

Fixes #120269

I'm unskipping task manager's jest integration tests by doing the following:

  • Since we no longer create a custom es client, change esStart.createClient to esStart.client
  • Move away from createErrorTransportRequestPromise which threw the exception right away and failed the test
  • Fake inlineScriptError to hit the code necessary to apply logic when scripts are disabled (not sure how this worked previously..)

@mikecote mikecote added release_note:skip Skip the PR/issue when compiling release notes Feature:Task Manager Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.3.0 labels Apr 14, 2022
@mikecote mikecote self-assigned this Apr 14, 2022
@mikecote
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mikecote

@mikecote mikecote marked this pull request as ready for review April 18, 2022 15:00
@mikecote mikecote requested a review from a team as a code owner April 18, 2022 15:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

ymao1
ymao1 approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikecote mikecote merged commit 4cccb69 into elastic:main Apr 18, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 18, 2022
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
@mikecote @kibanamachine @kertal
Unskip managed configuration integration test (elastic#130331)
1a880a7 
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymao1 ymao1 ymao1 approved these changes

Assignees

@mikecote mikecote

Labels
backport:skip This commit does not require backporting Feature:Task Manager release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test: Jest Integration Tests / managed configuration
5 participants
@mikecote @kibana-ci @elasticmachine @ymao1 @kibanamachine