Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Actionable Observability] Add rule details page #130330
[Actionable Observability] Add rule details page #130330
Changes from all commits
63f17af
d060c21
916f1eb
92d674c
a0a1143
7d13f2c
4869e1b
7aa6278
d91d20b
7543fb5
e448c45
3c64051
ee62107
ef50ff3
b25ab69
75b0163
02f7ce9
d9c8d97
8847e6c
f890c77
049cf3e
715c3ac
c00544c
c154c71
1c91182
91c67d2
17e3de9
6e3f7de
aafe700
dfc9b74
f4ee490
b56f59d
28404e4
0171d6e
8a63dd5
18684ed
f59d13b
367670f
4cf5873
b3d83ee
35159ae
03b1a08
6b4545a
8f4ee12
9c82aa1
dc40930
f41ca35
cad2366
8df5101
31711de
17f762e
5902eae
79a21f7
9ddb636
43a0b2d
2be30ff
35dec6c
488279d
e4cc2e2
954e4d5
0913468
7ec2adc
4a5c57a
a9e9704
e8fa815
888721b
8391aaf
080b723
23259b2
f10c901
4c7ddb3
32b3c6e
471a73f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fkanout I checked https://elastic.github.io/eui/#/display/icons and I tried to find rest logos, but I couldn't. Instead of adding rest application logs, I was thinking maybe we have a more dynamic way to retrieve the logos from existing functionality.
I will check out https://github.com/elastic/kibana/tree/main/x-pack/plugins/triggers_actions_ui/public/application/components/builtin_action_types and see if we can get something from there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fkanout I just investigated how we can get the icon dynamically and it looks like we can use the
actionTypeRegistry
from triggers_actions_ui to retrieve the iconClass. I quickly tested it out in your branch and it works. actionRegistry has a list method and we can get the iconClass from there!actionRegistry
we can get like this:This is not a complete code (no Typescript), just a proof of concept that we can dynamically get what we need. Do you want me to wrap it up and push directly to your branch? Or shall I fix it on another PR once this PR is merged? Whatever works for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for tracking purposes here's the issue that will fix this #132220