Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[User Experience] fix javascript errors href #130280

Merged
merged 2 commits into from
Apr 18, 2022
Merged

[User Experience] fix javascript errors href #130280

merged 2 commits into from
Apr 18, 2022

Conversation

dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented Apr 14, 2022 •
edited
Loading

Summary

Fixes: #130257
Relates to #78430

Adjusts the href for JavaScript errors on the User Experience page.
Screen Shot 2022-04-14 at 9 15 58 AM

Before
Screen Shot 2022-04-14 at 9 19 46 AM

After
Screen Shot 2022-04-14 at 11 18 44 AM

@dominiqueclarke dominiqueclarke added bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 labels Apr 14, 2022
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner April 14, 2022 15:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ux 170.1KB 170.2KB +45.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31
Copy link
Contributor

tested and works as ecpected

@shahzad31 shahzad31 merged commit 968dffa into elastic:main Apr 18, 2022
@shahzad31 shahzad31 deleted the fix/ux-javascript-errors-href branch April 18, 2022 07:22
kibanamachine pushed a commit that referenced this pull request Apr 18, 2022
@dominiqueclarke
[User Experience] fix javascript errors href (#130280)
0f59086 
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 968dffa)
@kibanamachine kibanamachine mentioned this pull request Apr 18, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 18, 2022
@kibanamachine @dominiqueclarke
[User Experience] fix javascript errors href (#130280) (#130445)
b406d2b 
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 968dffa)

Co-authored-by: Dominique Clarke <[email protected]>
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
@dominiqueclarke @kibanamachine @kertal
[User Experience] fix javascript errors href (elastic#130280)
ec934e6 
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.2.0 v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[User Experience] JavaScript error href links are broken
5 participants
@dominiqueclarke @elasticmachine @kibana-ci @shahzad31 @kibanamachine