Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Malwarescore + Ransomware EP alerts from DRule telemetry. #130233

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

pjhampton
Copy link
Contributor

Summary

This opens up endpoint alerts, but excludes Malwarescore and Ransomware alerts that we collect through event telemetry. This is so we can get information on endpoint promotion rules. Issue Backported.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@pjhampton pjhampton added release_note:fix Feature:Telemetry Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 v8.2.1 labels Apr 14, 2022
@pjhampton pjhampton self-assigned this Apr 14, 2022
@pjhampton pjhampton requested a review from a team as a code owner April 14, 2022 09:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@pjhampton
Copy link
Contributor Author

Testing in progress.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pjhampton

@pjhampton
Copy link
Contributor Author

Manual alert testing lgtm. Happy for this to release in next BC.

Copy link
Contributor

@donaherc donaherc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we now exclude:

  1. Malware Detection/Prevention alerts
  2. Ransomeware Detection/Prevention alerts

This is less restrictive than the previous implementation, which I think is the right call. AFAICT, (1) and (2) above are already sent up in endpoint alerts anyways?

@pjhampton pjhampton merged commit 4f6239d into main Apr 14, 2022
@pjhampton pjhampton deleted the pjhampton/drule-telemetry-query branch April 14, 2022 15:34
@pjhampton
Copy link
Contributor Author

This is less restrictive than the previous implementation, which I think is the right call. AFAICT, (1) and (2) above are already sent up in endpoint alerts anyways?

Yep!

kibanamachine pushed a commit that referenced this pull request Apr 14, 2022
…30233)

* Exclude malwarescore + ransomware endpoint alerts from sec telemetry.

* Remove endpoint module negation from query.

(cherry picked from commit 4f6239d)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@donaherc
Copy link
Contributor

donaherc commented Apr 14, 2022

kibanamachine added a commit that referenced this pull request Apr 14, 2022
…30233) (#130284)

* Exclude malwarescore + ransomware endpoint alerts from sec telemetry.

* Remove endpoint module negation from query.

(cherry picked from commit 4f6239d)

Co-authored-by: Pete Hampton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Telemetry release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.2.0 v8.2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants