-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RAM] Make RuleStatusDropdown shareable #130205
Merged
Zacqary
merged 16 commits into
elastic:main
from
Zacqary:129774-shareable-status-dropdown
Apr 19, 2022
Merged
Changes from 12 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
718fffc
Add shareable e dropdown and move snooze interval to localstorage
Zacqary 526dd9e
Add internal components sandbox page and status dropdown test
Zacqary 302423b
Remove components sandbox tab
Zacqary 5840a04
Merge remote-tracking branch 'upstream/main' into 129774-shareable-st…
Zacqary fcf0ce8
Fix typecheck
Zacqary da36afa
Merge remote-tracking branch 'upstream/main' into 129774-shareable-st…
Zacqary e67d15a
Fix typechecks and tests
Zacqary 8ce684d
Attempt to deflake tests
Zacqary e502295
Reenable previousSnoozeInterval from props and prefix storage key
Zacqary 1578db3
Export missing apis
Zacqary 0809620
Fix tooltip for indefinite snooze
Zacqary 0b05000
Attempt to deflake functional test
Zacqary 618e9c4
Modularize Sandbox
Zacqary 4bbb9bb
Merge remote-tracking branch 'upstream/main' into 129774-shareable-st…
Zacqary 6d644ed
Merge remote-tracking branch 'upstream/main' into 129774-shareable-st…
Zacqary c64111e
Up triggersActionsUi package limit
Zacqary File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
...public/application/internal/shareable_components_sandbox/shareable_components_sandbox.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import React, { useState } from 'react'; | ||
import { getRuleStatusDropdownLazy } from '../../../common/get_rule_status_dropdown'; | ||
|
||
export const InternalShareableComponentsSandbox: React.FC<{}> = () => { | ||
const [enabled, setEnabled] = useState(true); | ||
const [snoozeEndTime, setSnoozeEndTime] = useState<Date | null>(null); | ||
const [muteAll, setMuteAll] = useState(false); | ||
|
||
return getRuleStatusDropdownLazy({ | ||
rule: { | ||
enabled, | ||
snoozeEndTime, | ||
muteAll, | ||
}, | ||
enableRule: async () => { | ||
setEnabled(true); | ||
setMuteAll(false); | ||
setSnoozeEndTime(null); | ||
}, | ||
disableRule: async () => setEnabled(false), | ||
snoozeRule: async (time) => { | ||
if (time === -1) { | ||
setSnoozeEndTime(null); | ||
setMuteAll(true); | ||
} else { | ||
setSnoozeEndTime(new Date(time)); | ||
setMuteAll(false); | ||
} | ||
}, | ||
unsnoozeRule: async () => { | ||
setMuteAll(false); | ||
setSnoozeEndTime(null); | ||
}, | ||
onRuleChanged: () => {}, | ||
isEditable: true, | ||
}); | ||
}; | ||
|
||
// eslint-disable-next-line import/no-default-export | ||
export { InternalShareableComponentsSandbox as default }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So for the components that I'm working on, I am rebasing off of this branch since I also need to E2E test the components. I'm wondering if we could maybe move the rule status dropdown rendering to its own file? so I can add my components in this sandbox as well
maybe something like?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!