Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KibanaThemeProvider to GlobalSearchBar and Newsfeed plugins #130164

Merged
merged 7 commits into from
Apr 19, 2022
Merged

Add KibanaThemeProvider to GlobalSearchBar and Newsfeed plugins #130164

merged 7 commits into from
Apr 19, 2022

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Apr 13, 2022 •
edited
Loading

Summary

Adds the KibanaThemeProvider context layer to the GlobalSearchBar and Newsfeed plugins.
Fixes the color mode issue found in #130133 (global_search), and addresses the other known unwrapped plugin (newsfeed) mentioned during the implementation effort last year.

Screen Shot 2022-04-13 at 11 54 22 AM

For maintainers

@thompsongl thompsongl added release_note:skip Skip the PR/issue when compiling release notes ci:deploy-cloud v8.3.0 labels Apr 13, 2022
@thompsongl thompsongl requested a review from a team as a code owner April 13, 2022 16:59
@thompsongl thompsongl linked an issue Apr 13, 2022 that may be closed by this pull request
[Shared UX] Global search option: Bug – Highlighting search terms are not clearly visible in dark mode #130133
Closed
@thompsongl thompsongl requested a review from formgeist April 13, 2022 17:00
pgayvallet
pgayvallet reviewed Apr 13, 2022
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. just one thing:

src/plugins/newsfeed/kibana.json Outdated Show resolved Hide resolved
@thompsongl thompsongl requested a review from pgayvallet April 14, 2022 14:07
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
globalSearchBar 20.7KB 20.9KB +228.0B
newsfeed 9.7KB 9.9KB +214.0B
total +442.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

formgeist
formgeist approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@formgeist formgeist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

CleanShot 2022-04-19 at 09 34 47@2x

@thompsongl thompsongl merged commit db7237f into elastic:main Apr 19, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 19, 2022
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
@thompsongl @kertal
Add KibanaThemeProvider to GlobalSearchBar and Newsfeed plugins (…
62773b3 
…elastic#130164)

* add KibanaThemeProvider to GlobalSearchBar plugin

* add kibanaReact dep

* add KibanaThemeProvider to Newsfeed plugin

* kibanaReact to requiredBundles

* clean up imports
@jsanz jsanz mentioned this pull request Jun 27, 2022
Closed
@tylersmalley tylersmalley added ci:cloud-deploy Create or update a Cloud deployment and removed ci:deploy-cloud labels Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@formgeist formgeist formgeist approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment release_note:skip Skip the PR/issue when compiling release notes v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Shared UX] Global search option: Bug – Highlighting search terms are not clearly visible in dark mode
6 participants
@thompsongl @kibana-ci @pgayvallet @formgeist @tylersmalley @kibanamachine