[Ingest Pipelines] add tests for grok processor #130123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonelizabeth
added
chore
Team:Kibana Management
alisonelizabeth
commented
Apr 13, 2022
| @@ -1,57 +0,0 @@ | |||
| /* | |||
There was a problem hiding this comment.
No longer needed due to new tests added above. This appeared to be a one-off test located in the processors directory. The new tests were moved to the __jests__ directory to align with the other processor tests.
|
Pinging @elastic/platform-deployment-management (Team:Deployment Management) |
sabarasaba
approved these changes
Apr 14, 2022
alisonelizabeth
added
the
auto-backport
kibanamachine
pushed a commit
that referenced
this pull request
Apr 14, 2022
(cherry picked from commit 9e900a1)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
removed
the
backport missing
kibanamachine
added a commit
that referenced
this pull request
Apr 18, 2022
) * [Ingest Pipelines] add tests for grok processor (#130123) (cherry picked from commit 9e900a1) * update test Co-authored-by: Alison Goryachev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #129731
This PR adds some basic tests for the Grok processor to prevent regressions like #129731. The underlying issue was fixed via #128489.
Note: I ran this test pre-fix to confirm the test was failing, and is now passing with the fix.