[Enterprise Search] Rewire overview designs. #130066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@scottybollinger Didn't fixed the tests on purpose, I will most likely revert some changes I did on Product Selector and update them properly. Can you please take a look. |
...ations/enterprise_search_overview/components/getting_started_steps/getting_started_steps.tsx
Outdated
Show resolved
Hide resolved
...ations/enterprise_search_overview/components/getting_started_steps/getting_started_steps.tsx
Outdated
Show resolved
Hide resolved
...ublic/applications/enterprise_search_overview/components/getting_started_steps/icon_row.scss
Outdated
Show resolved
Hide resolved
- Fix issues caused by VS Code - Bind add content button for empty prompt - Add content icons to assets - Add text for icons and tooltip - Add link to Elasticsearch Guide - Add context menu for create button - Add some more css changes that VS Code deleted - Add Header popover to show deployment details - Filter SVG colors
efegurkan
added
release_note:skip
...h/public/applications/enterprise_search_overview/components/layout/kibana_header_actions.tsx
Show resolved
Hide resolved
…e_search_overview/components/layout/kibana_header_actions.tsx Co-authored-by: Scotty Bollinger <[email protected]>
|
@elasticmachine merge upstream |
Also made some changes to reduce the churn when we implement this feature
scottybollinger
approved these changes
Apr 21, 2022
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
daveyholler
approved these changes
Apr 21, 2022
There was a problem hiding this comment.
This looks good. I've got a few little design nits, but I'll pick them up in a round of polish. Thanks @efegurkan
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
May 24, 2022
* Rewire overview page with new designs - Fix issues caused by VS Code - Bind add content button for empty prompt - Add content icons to assets - Add text for icons and tooltip - Add link to Elasticsearch Guide - Add context menu for create button - Add some more css changes that VS Code deleted - Add Header popover to show deployment details - Filter SVG colors * Fix some issues * Review changes * Revert some more changes * Fix i18n issues * Lint fixes for sass file * Re-fix linting * Add render tests * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Update x-pack/plugins/enterprise_search/public/applications/enterprise_search_overview/components/layout/kibana_header_actions.tsx Co-authored-by: Scotty Bollinger <[email protected]> * Add tests for overview content Also made some changes to reduce the churn when we implement this feature Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Scotty Bollinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This screenshot is an example, doesn't include all of the components mentioned above
Adds components that are required for the new overview and Search indices empty state designs. Designs are intended for a later release. Originally this PR had the new design implementation as well, but reverted. New design implementation and the logic files will be added as a separate PR later.
x-pack/plugins/enterprise_search/public/applications/shared/add_content_emptyx-pack/plugins/enterprise_search/public/applications/shared/getting_started_stepsx-pack/plugins/enterprise_search/public/applications/shared/elasticsearch_resources- moved to sharedx-pack/plugins/enterprise_search/public/applications/enterprise_search_overview/components/layout/kibana_layer_actions.tsxChecklist
Delete any items that are not applicable to this PR.