Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Unskip flaky tests #130059

Merged
merged 6 commits into from
Apr 19, 2022
Merged

[Uptime] Unskip flaky tests #130059

merged 6 commits into from
Apr 19, 2022

Conversation

dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented Apr 12, 2022 •
edited
Loading

Summary

Fixes #88177
Fixes #116865
Fixes #93705
Fixes #85208

Unskips two flaky alerting tests. These have run successfully for a total of 300 iterations
Build 1 (200 iterations) https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/453
Build 2 (100 iterations) https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/438

Moves uptime Observer location test to Synthetics e2e tests

Unskips monitor states endpoint test. This has run successfully for a total of 200 iterations
Build 1 (200 iterations) https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/453

@dominiqueclarke dominiqueclarke added failed-test A test failure on a tracked branch, potentially flaky-test failed-es-promotion v8.2.0 release_note:skip Skip the PR/issue when compiling release notes v8.3.0 auto-backport Deprecated - use backport:version if exact versions are needed v8.1.3 v7.17.3 labels Apr 14, 2022
@dominiqueclarke dominiqueclarke marked this pull request as ready for review April 14, 2022 15:40
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner April 14, 2022 15:40
@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstream

@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Apr 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@dominiqueclarke dominiqueclarke changed the title unskip flaky test [Uptime] Unskip flaky tests Apr 14, 2022
@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dominiqueclarke dominiqueclarke merged commit 250e3f9 into elastic:main Apr 19, 2022
@dominiqueclarke dominiqueclarke deleted the fix/tls-alert-flaky-test branch April 19, 2022 16:10
@kibanamachine kibanamachine mentioned this pull request Apr 19, 2022
Closed
kibanamachine pushed a commit that referenced this pull request Apr 19, 2022
@dominiqueclarke
[Uptime] Unskip flaky tests (#130059)
0286372 
* unskip flaky test

* move Observer location test to Synthetics e2e

* uptime - update monitor states endpoint api integration tests

* uptime - reskip flaky tests

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 250e3f9)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
✅ 8.2
❌ 8.1 Backport failed because of merge conflicts
❌ 7.17 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 130059

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dominiqueclarke added a commit to dominiqueclarke/kibana that referenced this pull request Apr 20, 2022
@dominiqueclarke
[Uptime] Unskip flaky tests (elastic#130059)
40da471 
* unskip flaky test

* move Observer location test to Synthetics e2e

* uptime - update monitor states endpoint api integration tests

* uptime - reskip flaky tests

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 250e3f9)

# Conflicts:
#	x-pack/plugins/uptime/server/rest_api/uptime_route_wrapper.ts
@dominiqueclarke dominiqueclarke mentioned this pull request Apr 20, 2022
Closed
dominiqueclarke added a commit to dominiqueclarke/kibana that referenced this pull request Apr 20, 2022
@dominiqueclarke
[Uptime] Unskip flaky tests (elastic#130059)
f3b47be 
* unskip flaky test

* move Observer location test to Synthetics e2e

* uptime - update monitor states endpoint api integration tests

* uptime - reskip flaky tests

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 250e3f9)

# Conflicts:
#	x-pack/plugins/uptime/server/rest_api/uptime_route_wrapper.ts
@dominiqueclarke dominiqueclarke mentioned this pull request Apr 20, 2022
Closed
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 21, 2022
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

3 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@dominiqueclarke dominiqueclarke removed auto-backport Deprecated - use backport:version if exact versions are needed backport missing Added to PRs automatically when the are determined to be missing a backport. v8.2.0 v8.1.3 v7.17.3 labels Apr 27, 2022
@kibanamachine kibanamachine added backport:skip This commit does not require backporting labels Apr 27, 2022
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
@dominiqueclarke @kibanamachine @kertal
[Uptime] Unskip flaky tests (elastic#130059)
5aa9149 
* unskip flaky test

* move Observer location test to Synthetics e2e

* uptime - update monitor states endpoint api integration tests

* uptime - reskip flaky tests

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting failed-es-promotion failed-test A test failure on a tracked branch, potentially flaky-test release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/uptime/alert_flyout·ts - Uptime app with real-world data uptime alerts tls alert can save alert Failing ES Promotion: apis uptime uptime REST endpoints with generated data monitor state scoping test status filter should not return a monitor with mix state if check status filter is up Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/uptime/alert_flyout·ts - Uptime app with real-world data uptime alerts overview page alert flyout controls posts an alert, verifies its presence, and deletes the alert Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/uptime/locations·ts - Uptime app with generated data Observer location displays less monitor availability
5 participants
@dominiqueclarke @elasticmachine @kibana-ci @kibanamachine @shahzad31