Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Resizable/Collapsible Top Influencers section #130018

Merged
merged 9 commits into from
Apr 14, 2022
Merged

[ML] Resizable/Collapsible Top Influencers section #130018

merged 9 commits into from
Apr 14, 2022

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Apr 12, 2022 •
edited
Loading

Summary

  • Makes the Top influencers panel resizable and collapsible
  • Stored the collapsed state in the localStorage

Apr-13-2022 16-25-52

I also wanted to store the size of the panels but it's not possible at the moment (elastic/eui#5789)

Checklist

@darnautov darnautov mentioned this pull request Apr 13, 2022
Open
@darnautov darnautov force-pushed the ml-124696-collapsible-top-influencers branch from 2232218 to 7e97aa4 Compare April 13, 2022 11:29
@darnautov darnautov self-assigned this Apr 13, 2022
@darnautov darnautov added release_note:enhancement :ml Team:ML Team label for ML (also use :ml) v8.3.0 Feature:Anomaly Detection ML anomaly detection labels Apr 13, 2022
@darnautov darnautov marked this pull request as ready for review April 13, 2022 14:26
@darnautov darnautov requested review from a team as code owners April 13, 2022 14:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov darnautov requested a review from peteharverson April 13, 2022 14:28
ryankeairns
ryankeairns approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change!

SCSS: Removes unused styles.

peteharverson
peteharverson reviewed Apr 13, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Chrome, FF and Edge. Overall looks good. Just left one suggestion about the behavior for jobs with no influencer configured.

peteharverson
peteharverson approved these changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest changes and LGTM

@darnautov darnautov enabled auto-merge (squash) April 14, 2022 14:27
@darnautov darnautov merged commit 07341a5 into elastic:main Apr 14, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.3MB 3.3MB +535.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 14, 2022
@darnautov darnautov deleted the ml-124696-collapsible-top-influencers branch April 19, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@ryankeairns ryankeairns ryankeairns approved these changes

Assignees

@darnautov darnautov

Labels
backport:skip This commit does not require backporting Feature:Anomaly Detection ML anomaly detection :ml release_note:enhancement Team:ML Team label for ML (also use :ml) v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@darnautov @elasticmachine @kibana-ci @ryankeairns @peteharverson @kibanamachine