Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay Single User Journey Finish #129991

Closed
wants to merge 4 commits into from
Closed

Delay Single User Journey Finish #129991

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
091e840
add sleep before tearing down the browser page to guarantee transacti…
Apr 12, 2022
024d9aa
remove headless option
Apr 12, 2022
0171af1
add comment and use page.waitfortimeout
Apr 19, 2022
8c0ee00
Merge branch 'main' of github.com:elastic/kibana into 12-04-2022-dela…
Apr 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions x-pack/test/performance/services/performance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,8 @@ export class PerformanceTestingService extends FtrService {

private async tearDown(page: Page, client: CDPSession, context: BrowserContext) {
if (page) {
// Journey is delayed to finish to guarantee all events reported properly to APM.
await page.waitForTimeout(5000);
apm.flush();
await client.detach();
Comment on lines 171 to 172
Copy link
Member

@dmlemeshko dmlemeshko Apr 20, 2022 •
edited by spalger
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vigneshshanmugam suggested to add
await page.waitForResponse((response) => response.url().includes('/rum/events')); after flush() to make sure the RUM agent response is sent to APM server before browser is killed.

await page.close();
Expand Down