Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Endpoint] Add UT tests for fleet UI extensions components #129667

Merged
merged 11 commits into from
Apr 14, 2022
Merged

[Security Solution][Endpoint] Add UT tests for fleet UI extensions components #129667

merged 11 commits into from
Apr 14, 2022

Conversation

paul-tavares
Copy link
Contributor

@paul-tavares paul-tavares commented Apr 6, 2022 •
edited
Loading

Summary

  • Add new UT mock test render utilities for components that are rendered outside of Security Solution (ex. Fleet context)
  • Adds tests for the cards that are displayed in the Fleet's Endpoint Package Setting tab
  • Refactor of fleet's security solution rendering context

Checklist

@paul-tavares paul-tavares added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution OLM Sprint v8.3.0 labels Apr 6, 2022
@paul-tavares paul-tavares self-assigned this Apr 6, 2022
@paul-tavares paul-tavares marked this pull request as ready for review April 7, 2022 21:56
@paul-tavares paul-tavares requested review from a team as code owners April 7, 2022 21:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

joeypoon
joeypoon approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@joeypoon joeypoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@paul-tavares
Merge remote-tracking branch 'upstream/main' into task/olm-3527-tests…
e11e4e8 
…-for-fleet-extensions-components

# Conflicts:
#	x-pack/plugins/security_solution/public/management/pages/policy/view/ingest_manager_integration/endpoint_package_custom_extension/index.tsx
@paul-tavares
Adjust code after merge from main
ad94171 
added Joey's changes back in
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2773 2777 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.8MB 4.8MB +293.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 447 448 +1

Total ESLint disabled count

id before after diff
securitySolution 516 517 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @paul-tavares

@paul-tavares paul-tavares merged commit fd4bea9 into elastic:main Apr 14, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 14, 2022
@paul-tavares paul-tavares deleted the task/olm-3527-tests-for-fleet-extensions-components branch April 14, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeypoon joeypoon joeypoon approved these changes

@dasansol92 dasansol92 Awaiting requested review from dasansol92 dasansol92 was automatically assigned from elastic/security-onboarding-and-lifecycle-mgt

Assignees

@paul-tavares paul-tavares

Labels
backport:skip This commit does not require backporting OLM Sprint release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@paul-tavares @elasticmachine @kibana-ci @joeypoon @kibanamachine