removes :filters from label #12962
Merged
removes :filters from label #12962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisljar
added
Feature:Visualizations
|
Took me a little while to reproduce the problem. Split table with filters agg to reproduce. |
nreese
requested changes
Jul 19, 2017
| @@ -75,7 +75,10 @@ export function TabbedAggResponseWriterProvider(Private) { | |||
| if (group) { | |||
| table.aggConfig = agg; | |||
| table.key = key; | |||
| table.title = (table.fieldFormatter()(key)) + ': ' + agg.makeLabel(); | |||
| table.title = (table.fieldFormatter()(key)); | |||
| if (agg.makeLabel() !== 'filters') { | |||
There was a problem hiding this comment.
This problem really affects any aggregation that does not implement makeLabel function and relies on the default implementation (which just returns the aggregation name). How about instead of hard coding to check against filters you check that agg.makeLabel() !== agg.name? A comment about why this check is needed would also be helpful.
|
jenkins, test this |
ppisljar
force-pushed
the
fix/filterSplitLabel
branch
from
6f1c22a to
ca5e892
Compare
| table.title = (table.fieldFormatter()(key)) + ': ' + agg.makeLabel(); | ||
| table.title = (table.fieldFormatter()(key)); | ||
| // aggs that don't implement makeLabel should not add to title | ||
| if (agg.makeLabel() !== agg.name) { |
There was a problem hiding this comment.
Can we make this a method on the aggConfig. Something like isAggConfigOverridden, along those lines.
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Aug 1, 2017
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Aug 1, 2017
ppisljar
added a commit
that referenced
this pull request
Aug 1, 2017
ppisljar
added a commit
that referenced
this pull request
Aug 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12827