-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Detection Engine] Adds 8.2 rules #129526
[Detection Engine] Adds 8.2 rules #129526
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Personal checks:
- Checked version bumps were at least 1 above.
- 2 removed rules but I remember these from last month. 1 was considered a new rule but I worked this and the file name was duplicated so we fixed. Version is still 3 as it should be.
- Reviewed the
index.ts
file but these look like indexed imports referencing each rule. All new rules appear in the diff.
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
(cherry picked from commit 60e06c3)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
(cherry picked from commit 60e06c3) Co-authored-by: Justin Ibarra <[email protected]>
Summary
Pull updates to detection rules from https://github.com/elastic/detection-rules/tree/3844a00ffe2b812dade6499802a81773cbe8bfd7 (8.2 branch).
Checklist
Delete any items that are not applicable to this PR.
uses sentence case text and includes i18n support