Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Detection Engine] Adds 8.2 rules #129526

Merged

Conversation

brokensound77
Copy link
Contributor

@brokensound77 brokensound77 commented Apr 5, 2022

Summary

Pull updates to detection rules from https://github.com/elastic/detection-rules/tree/3844a00ffe2b812dade6499802a81773cbe8bfd7 (8.2 branch).

Checklist

Delete any items that are not applicable to this PR.

@brokensound77 brokensound77 requested a review from a team as a code owner April 5, 2022 19:57
@brokensound77 brokensound77 added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 labels Apr 5, 2022
Copy link
Contributor

@DefSecSentinel DefSecSentinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@terrancedejesus terrancedejesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Personal checks:

  • Checked version bumps were at least 1 above.
  • 2 removed rules but I remember these from last month. 1 was considered a new rule but I worked this and the file name was duplicated so we fixed. Version is still 3 as it should be.
  • Reviewed the index.ts file but these look like indexed imports referencing each rule. All new rules appear in the diff.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@brokensound77 brokensound77 merged commit 60e06c3 into elastic:main Apr 5, 2022
kibanamachine pushed a commit that referenced this pull request Apr 5, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@brokensound77 brokensound77 deleted the detection-rules/8.2-3844a00f branch April 5, 2022 23:35
kibanamachine added a commit that referenced this pull request Apr 6, 2022
(cherry picked from commit 60e06c3)

Co-authored-by: Justin Ibarra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants