unified search - iindex_pattern => data view type improvement #129506

mattkime · 2022-04-05T16:43:06Z

Summary

Use DataView class instead of IIndexPattern interface. IIndexPattern is ambiguous between the data view class instance and the serialized version of the data view.

Part of #107220

elasticmachine · 2022-04-05T18:51:42Z

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

x-pack/plugins/fleet/public/applications/fleet/components/search_bar.tsx

elasticmachine · 2022-04-05T19:54:15Z

Pinging @elastic/fleet (Team:Fleet)

...ic/applications/fleet/sections/agents/agent_details_page/components/agent_logs/query_bar.tsx

…ch_bar.tsx Co-authored-by: Nicolas Chaulet <[email protected]>

…/agent_details_page/components/agent_logs/query_bar.tsx Co-authored-by: Nicolas Chaulet <[email protected]>

weltenwort · 2022-04-06T09:33:08Z

x-pack/plugins/infra/public/pages/logs/stream/page_toolbar.tsx

@@ -57,7 +58,7 @@ export const LogsToolbar = () => {
          <QueryStringInput
            disableLanguageSwitcher={true}
            iconType="search"
-            indexPatterns={[derivedDataView]}
+            indexPatterns={[derivedDataView as DataView]}


Isn't this pretty risky? If the QueryStringInput requires a full DataView instance from now on, is there a way to provide one without all the overhead of persisting it?

If the QueryStringInput requires a full DataView instance from now on, is there a way to provide one without all the overhead of persisting it?

dataViews.create will create an instance without persisting.

We're working to remove all instances of faked data view instances. Is this happening in the infra code? Perhaps a new issue needs to be created to address this.

Yes, that derived data view is "fake". But if data views can now be created without persistence we can replace that. But let's do that separately 👍

paul-tavares

LGTM for x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/view/components/search_bar.tsx

👍

fkanout · 2022-04-06T10:09:12Z

x-pack/plugins/security_solution/public/common/components/query_bar/index.tsx

@@ -110,7 +111,7 @@ export const QueryBar = memo<QueryBarComponentProps>(
        dateRangeFrom={dateRangeFrom}
        dateRangeTo={dateRangeTo}
        filters={filters}
-        indexPatterns={indexPatterns}
+        indexPatterns={indexPatterns as DataView[]}


~~AFAIK indexPatterns uses only 3 class members from the DataView: id, title, and fields. Could we have a fitted version of DataView?~~

@mattkime, I misplaced my comment, It should be related to x-pack/plugins/observability/public/pages/alerts/components/alerts_search_bar.tsx. Sorry about that

fkanout · 2022-04-07T14:58:31Z

x-pack/plugins/observability/public/pages/alerts/components/alerts_search_bar.tsx

@@ -47,7 +48,7 @@ export function AlertsSearchBar({

  return (
    <SearchBar
-      indexPatterns={compatibleIndexPatterns}
+      indexPatterns={compatibleIndexPatterns as DataView[]}


This is ok as far as the prop indexPatterns exposed by SearchBar is the same type DataView
https://github.com/elastic/kibana/pull/129506/files#diff-c82e1b8d881f115132594175097c24185f00063c492eb44af979776de2218f53R42

@fkanout Its the responsibility of the owners of x-pack/plugins/observability to determine this is okay or to explain why its not. If its not okay we can review options to resolve the issue or leave this alone for now.

@XavierM, it would be helpful to get your inputs here, please.

Let's merge this one as the DataView type is used in both places. Later on, If the type needs to be changed, it will be handled in a different PR.

nchaulet

🚀

weltenwort

infra changes LGTM. we'll improve the fake data view creation separately

lukasolson

AppServices changes LGTM!

fkanout

Actionable Observability changes LGTM.

fkanout · 2022-04-11T08:14:05Z

x-pack/plugins/observability/public/pages/alerts/components/alerts_search_bar.tsx

@@ -47,7 +48,7 @@ export function AlertsSearchBar({

  return (
    <SearchBar
-      indexPatterns={compatibleIndexPatterns}
+      indexPatterns={compatibleIndexPatterns as DataView[]}


Let's merge this one as the DataView type is used in both places. Later on, If the type needs to be changed, it will be handled in a different PR.

mattkime · 2022-04-11T12:14:25Z

@elasticmachine merge upstream

kibana-ci · 2022-04-11T13:41:59Z

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id	before	after	diff
`data`	406	400	-6
`stackAlerts`	30	24	-6
`unifiedSearch`	255	163	-92
total			-104

History

💚 Build #36640 succeeded cd25d9e
💚 Build #36288 succeeded e594b32
💚 Build #36240 succeeded 2030add

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

iindex_pattern => data view

2030add

mattkime changed the title ~~iindex_pattern => data view~~ unified search - iindex_pattern => data view type improvement Apr 5, 2022

mattkime marked this pull request as ready for review April 5, 2022 18:44

mattkime requested review from a team as code owners April 5, 2022 18:44

mattkime requested review from joeypoon and paul-tavares April 5, 2022 18:44

mattkime added v8.3.0 Team:AppServicesSv labels Apr 5, 2022

mattkime added release_note:skip Skip the PR/issue when compiling release notes Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) labels Apr 5, 2022

nchaulet reviewed Apr 5, 2022

View reviewed changes

x-pack/plugins/fleet/public/applications/fleet/components/search_bar.tsx Outdated Show resolved Hide resolved

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Apr 5, 2022

nchaulet reviewed Apr 5, 2022

View reviewed changes

...ic/applications/fleet/sections/agents/agent_details_page/components/agent_logs/query_bar.tsx Outdated Show resolved Hide resolved

mattkime and others added 2 commits April 5, 2022 14:54

Update x-pack/plugins/fleet/public/applications/fleet/components/sear…

28b0909

…ch_bar.tsx Co-authored-by: Nicolas Chaulet <[email protected]>

Update x-pack/plugins/fleet/public/applications/fleet/sections/agents…

e594b32

…/agent_details_page/components/agent_logs/query_bar.tsx Co-authored-by: Nicolas Chaulet <[email protected]>

weltenwort reviewed Apr 6, 2022

View reviewed changes

paul-tavares approved these changes Apr 6, 2022

View reviewed changes

joeypoon approved these changes Apr 6, 2022

View reviewed changes

Merge branch 'main' into data_views_not_iindex_patterns

cd25d9e

fkanout reviewed Apr 7, 2022

View reviewed changes

nchaulet approved these changes Apr 7, 2022

View reviewed changes

weltenwort approved these changes Apr 7, 2022

View reviewed changes

lukasolson approved these changes Apr 7, 2022

View reviewed changes

fkanout approved these changes Apr 11, 2022

View reviewed changes

Merge branch 'main' into data_views_not_iindex_patterns

1e6e170

mattkime merged commit eeee6b9 into elastic:main Apr 11, 2022

kibanamachine added the backport:skip This commit does not require backporting label Apr 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

unified search - iindex_pattern => data view type improvement #129506

unified search - iindex_pattern => data view type improvement #129506

mattkime commented Apr 5, 2022 •

edited

Loading

elasticmachine commented Apr 5, 2022

elasticmachine commented Apr 5, 2022

weltenwort Apr 6, 2022 •

edited

Loading

mattkime Apr 6, 2022

weltenwort Apr 7, 2022

paul-tavares left a comment

fkanout Apr 6, 2022 •

edited

Loading

fkanout Apr 7, 2022

fkanout Apr 7, 2022

mattkime Apr 7, 2022

fkanout Apr 7, 2022

fkanout Apr 11, 2022

nchaulet left a comment

weltenwort left a comment

lukasolson left a comment

fkanout left a comment

fkanout Apr 11, 2022

mattkime commented Apr 11, 2022

kibana-ci commented Apr 11, 2022

References to deprecated APIs

unified search - iindex_pattern => data view type improvement #129506

unified search - iindex_pattern => data view type improvement #129506

Conversation

mattkime commented Apr 5, 2022 • edited Loading

Summary

elasticmachine commented Apr 5, 2022

elasticmachine commented Apr 5, 2022

weltenwort Apr 6, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paul-tavares left a comment

Choose a reason for hiding this comment

fkanout Apr 6, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nchaulet left a comment

Choose a reason for hiding this comment

weltenwort left a comment

Choose a reason for hiding this comment

lukasolson left a comment

Choose a reason for hiding this comment

fkanout left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mattkime commented Apr 11, 2022

kibana-ci commented Apr 11, 2022

💚 Build Succeeded

Metrics [docs]

References to deprecated APIs

History

mattkime commented Apr 5, 2022 •

edited

Loading

weltenwort Apr 6, 2022 •

edited

Loading

fkanout Apr 6, 2022 •

edited

Loading