Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[artifacts] Merge docker context verification #129399

Merged
merged 4 commits into from
Apr 4, 2022
Merged

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Apr 4, 2022

This adds the docker context verification steps to our artifacts pipeline, with the intention of testing final artifacts before they're released. The current pipeline will be shut off when this pipeline is enabled

@jbudz
Copy link
Member Author

jbudz commented Apr 4, 2022

@jbudz jbudz added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 v8.3.0 v7.17.3 labels Apr 4, 2022
@jbudz jbudz marked this pull request as ready for review April 4, 2022 19:42
@jbudz jbudz requested a review from a team as a code owner April 4, 2022 19:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@tylersmalley
Copy link
Contributor

Do you think this needs to run on every build? What if we only ran with changes to src/dev and on tracked branches?

@jbudz
Copy link
Member Author

jbudz commented Apr 4, 2022

I think we should run it for every "release"/BC build, but we could shut it off for snapshots? Timing would initially be daily vs every commit.

This will only run on tracked branches though, so I don't think we have a whenChanged equivalent ouside of pull requests do we?

@tylersmalley
Copy link
Contributor

Ah, ok - didn't realize it was the assets pipeline.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz merged commit b2b961e into main Apr 4, 2022
@jbudz jbudz deleted the artifacts/test-docker-context branch April 4, 2022 21:41
kibanamachine pushed a commit that referenced this pull request Apr 4, 2022
* [artifacts] Merge docker context verification

* add to pipeline

* n2-2

(cherry picked from commit b2b961e)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.2
7.17 Backport failed because of merge conflicts

You might need to backport the following PRs to 7.17:
- [artifacts] Merge package testing with release artifacts (#129378)

Manual backport

To create the backport manually run:

node scripts/backport --pr 129399

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jbudz added a commit that referenced this pull request Apr 4, 2022
* [artifacts] Merge docker context verification

* add to pipeline

* n2-2
kibanamachine added a commit that referenced this pull request Apr 4, 2022
* [artifacts] Merge docker context verification

* add to pipeline

* n2-2

(cherry picked from commit b2b961e)

Co-authored-by: Jonathan Budzenski <[email protected]>
jbudz added a commit that referenced this pull request Apr 5, 2022
* [artifacts] Merge docker context verification

* add to pipeline

* n2-2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.17.3 v8.2.0 v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants