Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecuritySolution] update sourcer messages #129329

Merged
merged 9 commits into from
Apr 12, 2022
Merged

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Apr 4, 2022

Summary

issue: #121984

  1. Create a timeline template with auditbeat-* in timeline sourcerer

  2. Go to Kibana advanced settings, and remove auditbeat-* from Security Solution's Elasticsearch indices

Screenshot 2022-03-17 at 01 42 29

  1. Refresh the page and open the timeline template you just created, the call out should say
    This timeline template is out of date with the Security Data View

We have preserved your timeline template by creating a temporary data view. If you'd like to modify your data, we can add the missing index patterns to the Security Data View. You can also manually select a data view here.

  1. Go back to Kibana advanced settings and reset the indices to default settings.

  2. Start over again from step 1, but create a timeline instead. When opening the sourcerer of timeline, it should say
    This timeline is out of date with the Security Data View

We have preserved your timeline by creating a temporary data view. If you'd like to modify your data, we can add the missing index patterns to the Security Data View. You can also manually select a data view here.

Screenshot 2022-04-04 at 18 09 45

sourcerer.mp4

Checklist

Delete any items that are not applicable to this PR.

@angorayc angorayc added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.1.0 Team:Threat Hunting:Explore v8.2.0 labels Apr 4, 2022
@angorayc angorayc requested a review from stephmilovic April 4, 2022 11:51
@angorayc angorayc requested a review from a team as a code owner April 4, 2022 11:51
@angorayc angorayc self-assigned this Apr 4, 2022
@@ -0,0 +1,201 @@
/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FormattedMessage doesn’t accept its props to be variables (The build will fail and complain about this), so I created components to return messages by timeline type.

Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2782 2783 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.8MB 4.8MB +2.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @angorayc

@angorayc angorayc merged commit 6366f37 into elastic:main Apr 12, 2022
kibanamachine pushed a commit that referenced this pull request Apr 12, 2022
* update wording for temporary sourcerer

* update sourcer messages

* add message utils

* fix FormattedMessage

* remove unused i18n keys

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 6366f37)
kibanamachine pushed a commit that referenced this pull request Apr 12, 2022
* update wording for temporary sourcerer

* update sourcer messages

* add message utils

* fix FormattedMessage

* remove unused i18n keys

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 6366f37)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.1
8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 12, 2022
* update wording for temporary sourcerer

* update sourcer messages

* add message utils

* fix FormattedMessage

* remove unused i18n keys

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 6366f37)

Co-authored-by: Angela Chuang <[email protected]>
kibanamachine added a commit that referenced this pull request Apr 12, 2022
* update wording for temporary sourcerer

* update sourcer messages

* add message utils

* fix FormattedMessage

* remove unused i18n keys

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 6366f37)

Co-authored-by: Angela Chuang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore v8.1.0 v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants