Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.2] [RAM] Add error logs in rule details page #129278

Merged
merged 2 commits into from
Apr 3, 2022

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Apr 3, 2022

Backport

This will backport the following commits from main to 8.2:

Questions ?

Please refer to the Backport tool documentation

XavierM added 2 commits April 3, 2022 08:32
* add error log on details page + snooze

* refresh table in details page

* fix type

* add + fix jest test

* add test for error log

* remove console

* update functional test + delete flaky jest test + fix i18n

* review I

* remove skip

* review II

* remove disable panel

* clean up design

* fix check

* fix types

* Design tweaks to header, status dropdown, mobile

* remove dead code

* jest test

* fix actions layout

* review III

Co-authored-by: Ryan Keairns <[email protected]>
(cherry picked from commit d6b8e4b)
@XavierM XavierM enabled auto-merge (squash) April 3, 2022 12:40
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
triggersActionsUi 358 359 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
alerting 316 325 +9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 699.5KB 697.0KB -2.6KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
alerting 21 20 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 98.6KB 98.6KB -4.0B
Unknown metric groups

API count

id before after diff
alerting 324 333 +9

async chunk count

id before after diff
triggersActionsUi 73 75 +2

ESLint disabled line counts

id before after diff
triggersActionsUi 160 164 +4

Total ESLint disabled count

id before after diff
triggersActionsUi 166 170 +4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit 2aa076a into elastic:8.2 Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants