Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide welcome page privacy statement on cloud instances #129198

Merged
merged 5 commits into from
Apr 12, 2022
Merged

Hide welcome page privacy statement on cloud instances #129198

merged 5 commits into from
Apr 12, 2022

Conversation

gsoldevila
Copy link
Contributor

@gsoldevila gsoldevila commented Apr 1, 2022 •
edited
Loading

Solves #110638

In order to be able to conditionally hide the privacy statement (welcome page and notification banner) on cloud instances, we create a new hidePrivacyStatement flag in the Telemetry Plugin configuration.

This flag will be false by default, not altering the current display logic.

Then, we will create a separate PR in cloud to override the default value to true.

@gsoldevila gsoldevila added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.3.0 labels Apr 1, 2022
@gsoldevila gsoldevila requested review from a team as code owners April 1, 2022 13:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

afharo
afharo approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this!

Bamieh
Bamieh approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsoldevila gsoldevila added v8.2.0 auto-backport Deprecated - use backport:version if exact versions are needed backport-v8.0.0 and removed backport:skip This commit does not require backporting labels Apr 4, 2022
@gsoldevila gsoldevila enabled auto-merge (squash) April 12, 2022 08:08
@gsoldevila gsoldevila requested a review from a team as a code owner April 12, 2022 09:09
azasypkin
azasypkin approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in expectedExposedConfigKeys LGTM (from security perspective).

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
telemetry 27.5KB 27.6KB +70.0B
Unknown metric groups

API count

id before after diff
telemetry 43 44 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@gsoldevila gsoldevila merged commit 7849d9e into elastic:main Apr 12, 2022
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.2 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 129198

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 129198 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 14, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 129198 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 129198 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 129198 or prevent reminders by adding the backport:skip label.

@gsoldevila gsoldevila mentioned this pull request Apr 19, 2022
Merged
gsoldevila added a commit to gsoldevila/kibana that referenced this pull request Apr 19, 2022
@gsoldevila
Hide welcome page privacy statement on cloud instances (elastic#129198)
76d5f73 
* Add new hidePrivacyStatement flag to Telemetry

* Remove hidePrivacyStatement from asciidocs

(cherry picked from commit 7849d9e)
gsoldevila added a commit that referenced this pull request Apr 19, 2022
@gsoldevila
Hide welcome page privacy statement on cloud instances (#129198) (#13…
f45a06f 
…0547)

* Add new hidePrivacyStatement flag to Telemetry

* Remove hidePrivacyStatement from asciidocs

(cherry picked from commit 7849d9e)
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bamieh Bamieh Bamieh approved these changes

@afharo afharo afharo approved these changes

@jbudz jbudz jbudz approved these changes

@azasypkin azasypkin azasypkin approved these changes

@lukeelmers lukeelmers lukeelmers approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.2.0 v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@gsoldevila @elasticmachine @kibana-ci @kibanamachine @lukeelmers @azasypkin @jbudz @afharo @Bamieh