Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting] Improve comparator types of es_query && index_threshold rules #129190

Merged
merged 4 commits into from
Apr 7, 2022
Merged

[Alerting] Improve comparator types of es_query && index_threshold rules #129190

merged 4 commits into from
Apr 7, 2022

Conversation

dimaanj
Copy link
Contributor

@dimaanj dimaanj commented Apr 1, 2022

Summary

This PR is one of the follow ups of #124534. It gets rid of redundant type casting. Solution was introduced #129184.

@dimaanj dimaanj added Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.3.0 labels Apr 1, 2022
@dimaanj dimaanj self-assigned this Apr 1, 2022
@dimaanj dimaanj requested a review from kertal April 1, 2022 11:40
@dimaanj dimaanj marked this pull request as ready for review April 4, 2022 12:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@dimaanj
Copy link
Contributor Author

dimaanj commented Apr 4, 2022

@elasticmachine merge upstream

@kertal kertal self-requested a review April 6, 2022 06:26
kertal
kertal approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx for the cleanup!

@dimaanj
Copy link
Contributor Author

dimaanj commented Apr 7, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dmitriynj

@dimaanj dimaanj merged commit 3522a7f into elastic:main Apr 7, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo left review comments

@kertal kertal kertal approved these changes

Assignees

@dimaanj dimaanj

Labels
backport:skip This commit does not require backporting Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dimaanj @elasticmachine @kibana-ci @kertal @afharo @kibanamachine