Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gauge field formatters #12913

Merged
merged 1 commit into from
Jul 18, 2017
Merged

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Jul 17, 2017

closes #12838

Release Note: metric/goal/gauge now correctly respect the fieldFormatters when multiple metrics are defined.

@ppisljar ppisljar added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v6.0.0 labels Jul 17, 2017
@ppisljar ppisljar requested review from thomasneirynck and Bargs July 17, 2017 08:55
@ppisljar ppisljar force-pushed the fix/gaugeFieldFormatter branch from c46185e to d0a298f Compare July 17, 2017 09:12
Copy link
Contributor

@Bargs Bargs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppisljar ppisljar merged commit 7da4efe into elastic:master Jul 18, 2017
ppisljar added a commit to ppisljar/kibana that referenced this pull request Jul 19, 2017
@ppisljar ppisljar deleted the fix/gaugeFieldFormatter branch July 19, 2017 08:15
ppisljar added a commit that referenced this pull request Jul 19, 2017
ppisljar added a commit to ppisljar/kibana that referenced this pull request Jul 19, 2017
@jimgoodwin
Copy link

@ppisljar Release Note: paragraph in the description saying what was fixed

ppisljar added a commit that referenced this pull request Jul 27, 2017
@kdawoud
Copy link

kdawoud commented Aug 4, 2017

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:fix review v5.6.0 v6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metric vis with multiple metrics may use incorrect field formatters
5 participants