-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix gauge field formatters #12913
Merged
Merged
fix gauge field formatters #12913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisljar
added
Feature:Visualizations
Generic visualization features (in case no more specific feature label is available)
review
v6.0.0
labels
Jul 17, 2017
ppisljar
force-pushed
the
fix/gaugeFieldFormatter
branch
from
July 17, 2017 09:12
c46185e
to
d0a298f
Compare
thomasneirynck
approved these changes
Jul 17, 2017
Bargs
approved these changes
Jul 18, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Jul 19, 2017
ppisljar
added a commit
that referenced
this pull request
Jul 19, 2017
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Jul 19, 2017
@ppisljar Release Note: paragraph in the description saying what was fixed |
ppisljar
added a commit
that referenced
this pull request
Jul 27, 2017
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Visualizations
Generic visualization features (in case no more specific feature label is available)
release_note:fix
review
v5.6.0
v6.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12838
Release Note: metric/goal/gauge now correctly respect the fieldFormatters when multiple metrics are defined.