Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds the Lens 8.2.0 docs #128986

Merged
merged 8 commits into from
Apr 6, 2022
Merged

Adds the Lens 8.2.0 docs #128986

merged 8 commits into from
Apr 6, 2022

Conversation

KOTungseth
Copy link
Contributor

@KOTungseth KOTungseth commented Mar 30, 2022 •
edited
Loading

@KOTungseth KOTungseth added Team:Docs release_note:skip Skip the PR/issue when compiling release notes Feature:Lens auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 labels Mar 30, 2022
@KOTungseth KOTungseth self-assigned this Mar 30, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

drewdaemon
drewdaemon requested changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

We decided to go with "Explore raw data" in place of "Open in Discover." I've updated the text in my most recent PR.

I just looked at the "Explore raw data" feature... I think @mbondyra can better review the annotations stuff.

docs/user/dashboard/lens.asciidoc Outdated Show resolved Hide resolved
@KOTungseth
Copy link
Contributor Author

@elasticmachine merge upstream

mbondyra
mbondyra reviewed Mar 31, 2022
View reviewed changes
docs/user/dashboard/lens.asciidoc
Annotations allow you to call out specific points in your visualizations that are important, such as a major change in the data. You can add text and icons to annotations and customize the appearance, such as the line format and color.

[role="screenshot"]
image::images/lens_annotations_8.2.0.png[Lens annotations]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious about this screenshot - this doesn't look like a default annotation. However, user can configure the annotation to look like it so I guess it can be fine 🆗

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to add a screenshot that sparkled a little brighter than the default :) I can change it! But I kind of like it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's all good, let's leave it this way :)

gchaps
gchaps approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor suggestion.

docs/user/dashboard/lens.asciidoc Outdated Show resolved Hide resolved
@KOTungseth
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @KOTungseth

drewdaemon
drewdaemon approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@KOTungseth KOTungseth merged commit e046687 into elastic:main Apr 6, 2022
@KOTungseth KOTungseth deleted the docs/lens-8.2 branch April 6, 2022 17:50
@kibanamachine kibanamachine mentioned this pull request Apr 6, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Apr 6, 2022
@KOTungseth
Adds the Lens 8.2.0 docs (#128986)
6afbafc 
* Adds the Lens 8.2.0 docs

* Review comments

* Update Discover setting

* Update Discover setting

* Update Discover setting

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit e046687)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 6, 2022
@kibanamachine @KOTungseth
Adds the Lens 8.2.0 docs (#128986) (#129640)
6642f69 
* Adds the Lens 8.2.0 docs

* Review comments

* Update Discover setting

* Update Discover setting

* Update Discover setting

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit e046687)

Co-authored-by: Kaarina Tungseth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaps gchaps gchaps approved these changes

@mbondyra mbondyra mbondyra approved these changes

@MichaelMarcialis MichaelMarcialis MichaelMarcialis left review comments

@drewdaemon drewdaemon drewdaemon approved these changes

@dej611 dej611 Awaiting requested review from dej611

@ghudgins ghudgins Awaiting requested review from ghudgins

Assignees

@KOTungseth KOTungseth

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@KOTungseth @elasticmachine @kibana-ci @kibanamachine @drewdaemon @MichaelMarcialis @mbondyra @ghudgins @gchaps