[RAM} Add refine search prompt to rule execution log #128982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiaweiWu
added
release_note:enhancement
Team:ResponseOps
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
JiaweiWu
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
💛 Build succeeded, but was flakyTest FailuresMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
XavierM
reviewed
Apr 4, 2022
| @@ -256,6 +257,10 @@ export const RuleErrorLog = (props: RuleErrorLogProps) => { | |||
| } | |||
| }} | |||
| /> | |||
| <RefineSearchPrompt | |||
XavierM
approved these changes
Apr 4, 2022
kibanamachine
pushed a commit
that referenced
this pull request
Apr 5, 2022
* Refine search prompt * Add refine prompt to error log table Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 2fd6772)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 5, 2022
* Refine search prompt * Add refine prompt to error log table Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 2fd6772) Co-authored-by: Jiawei Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves: #128811
Adds a prompt to notify the use that they should refine their search if it is too broad. Similar to how it is done in the discover plugin. The current threshold is 500 as discussed here: #127339 (comment)