Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v53.0.1 #128825

Merged
merged 7 commits into from
Mar 31, 2022
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
"@elastic/datemath": "link:bazel-bin/packages/elastic-datemath",
"@elastic/elasticsearch": "npm:@elastic/[email protected]",
"@elastic/ems-client": "8.2.0",
"@elastic/eui": "52.2.0",
"@elastic/eui": "53.0.1",
"@elastic/filesaver": "1.1.2",
"@elastic/node-crypto": "1.2.1",
"@elastic/numeral": "^2.5.1",
Expand Down
82 changes: 80 additions & 2 deletions src/core/public/i18n/__snapshots__/i18n_service.test.tsx.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 25 additions & 1 deletion src/core/public/i18n/i18n_eui_mapping.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,31 @@ describe('@elastic/eui i18n tokens', () => {
test('defaultMessage is in sync with defString', () => {
// Certain complex tokens (e.g. ones that have a function as a defaultMessage)
// need custom i18n handling, and can't be checked for basic defString equality
const tokensToSkip = ['euiColumnSorting.buttonActive', 'euiSelectable.searchResults'];
const tokensToSkip = [
cee-chen marked this conversation as resolved.
Show resolved Hide resolved
'euiColumnSorting.buttonActive',
'euiSelectable.searchResults',
'euiPrettyDuration.lastDurationSeconds',
'euiPrettyDuration.nextDurationSeconds',
'euiPrettyDuration.lastDurationMinutes',
'euiPrettyDuration.nextDurationMinutes',
'euiPrettyDuration.lastDurationHours',
'euiPrettyDuration.nextDurationHours',
'euiPrettyDuration.lastDurationDays',
'euiPrettyDuration.nexttDurationDays',
'euiPrettyDuration.lastDurationWeeks',
'euiPrettyDuration.nextDurationWeeks',
'euiPrettyDuration.lastDurationMonths',
'euiPrettyDuration.nextDurationMonths',
'euiPrettyDuration.lastDurationYears',
'euiPrettyDuration.nextDurationYears',
'euiPrettyInterval.seconds',
'euiPrettyInterval.minutes',
'euiPrettyInterval.hours',
'euiPrettyInterval.days',
'euiPrettyInterval.weeks',
'euiPrettyInterval.months',
'euiPrettyInterval.years',
];
if (tokensToSkip.includes(token)) return;

// Clean up typical errors from the `@elastic/eui` extraction token tool
Expand Down
Loading