Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actionable Observability] filter by o11y rule types #128370

Merged
merged 7 commits into from
Mar 28, 2022

Conversation

mgiota
Copy link
Contributor

@mgiota mgiota commented Mar 23, 2022

Fixes #127012

Notes for the reviewer

  const {
      kibanaFeatures
  } = useKibana().services;
  • That's why I ended up using const { ObservabilityPageTemplate, kibanaFeatures } = usePluginContext();

Let me know if you have a better recommendation or if it is fine the way I did it.

Screen.Recording.2022-03-23.at.14.59.48.mov

@mgiota mgiota changed the title 127012 filter per o11y rule types [Actionable Observability] filter by o11y rule types Mar 23, 2022
@mgiota mgiota force-pushed the 127012_filter_per_o11y_rule_types branch from a7ecd07 to 52bf722 Compare March 23, 2022 13:56
@mgiota mgiota self-assigned this Mar 23, 2022
@mgiota mgiota added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.2.0 release_note:skip Skip the PR/issue when compiling release notes labels Mar 23, 2022
@mgiota mgiota marked this pull request as ready for review March 23, 2022 14:10
@mgiota mgiota requested a review from a team as a code owner March 23, 2022 14:10
@mgiota mgiota force-pushed the 127012_filter_per_o11y_rule_types branch from c409f4b to adf271a Compare March 23, 2022 23:01
@mgiota mgiota enabled auto-merge (squash) March 24, 2022 08:26
@mgiota
Copy link
Contributor Author

mgiota commented Mar 28, 2022

@elasticmachine merge upstream

@mgiota
Copy link
Contributor Author

mgiota commented Mar 28, 2022

@elastic/unified-observability Could somebody look into this please? We aim to get it in for 8.2

cc @emma-raffenne @katrin-freihofner @vinaychandrasekhar

@mgiota
Copy link
Contributor Author

mgiota commented Mar 28, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 388 389 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 363 365 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 424.0KB 425.6KB +1.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 91.0KB 91.1KB +74.0B
Unknown metric groups

API count

id before after diff
observability 366 368 +2

ESLint disabled line counts

id before after diff
observability 41 42 +1

Total ESLint disabled count

id before after diff
observability 44 45 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mgiota

@afgomez afgomez self-requested a review March 28, 2022 12:06
Copy link
Contributor

@afgomez afgomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not excited about adding something else to usePluginContext but for now it's OK.

I added a tiny comment. If no changes are necessary in that feel free to merge.

onChange(selectedValues);
}
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [selectedValues]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the reason to skip the onChange from the dependency list?

@mgiota mgiota merged commit 2dfc0b9 into elastic:main Mar 28, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 128370 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 30, 2022
@emma-raffenne emma-raffenne added the backport:skip This commit does not require backporting label Mar 30, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 30, 2022
@mgiota mgiota deleted the 127012_filter_per_o11y_rule_types branch May 10, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter per observability rule types
5 participants