You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
Risk
Probability
Severity
Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.
Low
High
Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.
High
Low
Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.
Medium
High
Unit tests will verify that any feature flag or plugin combination still results in our service operational.
[job][logs] Jest Tests #4 / alert actions determineToAndFrom it uses original_time and threshold_result.from for threshold alerts
[job][logs] Jest Tests #4 / alert actions sendAlertToTimelineAction apolloClient is not defined it invokes createTimeline with timelineDefaults
[job][logs] Jest Tests #4 / alert actions sendAlertToTimelineAction Eql with NO signal.group.id
[job][logs] Jest Tests #4 / alert actions sendAlertToTimelineAction Eql with signal.group.id
[job][logs] Jest Tests #4 / alert actions sendAlertToTimelineAction timeline id is NOT empty string and apollo client exists it invokes createTimeline with default timeline if apolloClient throws
[job][logs] Jest Tests #4 / alert actions sendAlertToTimelineAction timeline id is NOT empty string and apollo client exists it invokes createTimeline with designated timeline template if "timelineTemplate" exists
[job][logs] Jest Tests #4 / alert actions sendAlertToTimelineAction timelineId is empty string it invokes createTimeline with timelineDefaults
[job][logs] Jest Tests #4 / alert actions show toasts when data is malformed renders a toast and calls create timeline with basic defaults
[job][logs] Jest Tests #3 / GraphOverlay when used in an events viewer (i.e. in the Detections view, or the Host > Events view) it gets index pattern from default data view
[job][logs] Jest Tests #3 / GraphOverlay when used in an events viewer (i.e. in the Detections view, or the Host > Events view) it has 100% width when NOT in full screen mode
[job][logs] Jest Tests #3 / GraphOverlay when used in an events viewer (i.e. in the Detections view, or the Host > Events view) it has a fixed position when in full screen mode
[job][logs] Jest Tests #3 / GraphOverlay when used in the active timeline it gets index pattern from Timeline data view
Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.
Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.
The reason will be displayed to describe this comment to others. Learn more.
Session view callbacks looks good to me! I am wondering if we want to utilize the jumpToEvent prop now for session view in Alerts, to have session view jump to the event that triggered the alert.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Based on this PR: #127991
Screen.Recording.2022-03-23.at.9.21.29.AM.mov
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers